-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experiment tracking setup from viz starters #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Briefly went through the code for these starters and I think there's some datasets in the catalog which refer to the tracking datasets so you might need to update the pipelines and the catalog as well.
metrics:
type: tracking.MetricsDataset
filepath: data/09_tracking/metrics.json
companies_columns:
type: tracking.JSONDataset
filepath: data/09_tracking/companies_columns.json
Hi @ankatiyar and @DimedS , I am not sure if it is worth to keep the viz starters after removing ET. The difference I see are the plotly charts. I feel we can keep the viz starters and rename them to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. As for removing the starters entirely might require significant rework of the project creation flow and warrants some discussion. I left a comment on the main issue too kedro-org/kedro-viz#2202
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ravi-kumar-pilla! I agree that we should consider highlighting something additional related to Viz in the starter, rather than removing it. Removing it would result in a significant change to the kedro new workflow.
Motivation and Context
Resolves kedro-org/kedro#4371
How has this been tested?
Checklist