Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Run Command Component in kedro-viz (General) #1945

Open
3 of 4 tasks
Huongg opened this issue Jun 13, 2024 · 5 comments
Open
3 of 4 tasks

The Run Command Component in kedro-viz (General) #1945

Huongg opened this issue Jun 13, 2024 · 5 comments
Assignees
Labels
Design: UX Design: Visual Design Javascript Pull requests that update Javascript code

Comments

@Huongg
Copy link
Contributor

Huongg commented Jun 13, 2024

Description

The parent ticket is: #1753

The run command component will display the real-time command needed to achieve the current view in viz. This ticket is part of the larger ticket #1784, "Make Kedro-Viz flowchart filterable."

Context

This feature is important because it allows users to see the exact commands required to replicate the current visualization. This helps users understand how it can be run the kedro framework via CLI, enabling better debugging, learning, and sharing of workflows.

Tasks:

  • Design the user interface for the run command component.
  • Implement the logic to generate and update commands in real time based on the current visualization state.
  • Ensure the command line shown in viz is integrates smoothly with the existing approach from framework.

Checklist

  • Include labels so that we can categorise your feature request
@Huongg Huongg added this to Kedro-Viz Jun 13, 2024
@Huongg Huongg moved this to Todo in Kedro-Viz Jun 13, 2024
@Huongg Huongg moved this from Todo to In Progress in Kedro-Viz Jun 13, 2024
@Huongg Huongg self-assigned this Jun 24, 2024
@Huongg Huongg changed the title The Run Command Component in kedro-viz (General) SPIKE: The Run Command Component in kedro-viz (General) Jun 24, 2024
@Huongg Huongg moved this from In Progress to Todo in Kedro-Viz Jun 24, 2024
@Huongg Huongg moved this from Todo to In Progress in Kedro-Viz Jun 27, 2024
@Huongg
Copy link
Contributor Author

Huongg commented Jun 27, 2024

As discussed with @stephkaiser, I'm now going to do a spike work on how this works technically first while she's looking at the design for 1944

cc @rashidakanchwala @jitu5

@Huongg
Copy link
Contributor Author

Huongg commented Jul 4, 2024

I've done a first around of spike work here, where I created a new selector to handle all the command lines and connect with the UI component

Screenshot 2024-07-04 at 12 32 38

A gif to briefly show how the flow works at the moment:

runcommand-ezgif com-video-to-gif-converter

@stephkaiser stephkaiser moved this from In Progress to In Review in Kedro-Viz Aug 1, 2024
@rashidakanchwala rashidakanchwala moved this from In Review to Done in Kedro-Viz Aug 5, 2024
@rashidakanchwala
Copy link
Contributor

Is this done? @Huongg

@Huongg
Copy link
Contributor Author

Huongg commented Nov 4, 2024

hey @rashidakanchwala not 100% done, it's only done for the slicing pipeline part, but not for other features

@Huongg
Copy link
Contributor Author

Huongg commented Nov 13, 2024

@stephkaiser has led the design work for the run-command, which you can view here

Screenshot 2024-11-13 at 10 12 37

The next step will be to decide where in the UI the run command should appear—such as when switching pipelines or selecting a node/element?

cc @astrojuanlu and @stephkaiser for any further discussion on this

@Huongg Huongg moved this from Done to Inbox in Kedro-Viz Nov 13, 2024
@Huongg Huongg changed the title SPIKE: The Run Command Component in kedro-viz (General) The Run Command Component in kedro-viz (General) Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design: UX Design: Visual Design Javascript Pull requests that update Javascript code
Projects
Status: Inbox
Development

No branches or pull requests

3 participants