Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure project logs of INFO level are shown #2520

Closed
Tracked by #2205
antonymilne opened this issue Apr 17, 2023 · 1 comment · Fixed by #2684
Closed
Tracked by #2205

Make sure project logs of INFO level are shown #2520

antonymilne opened this issue Apr 17, 2023 · 1 comment · Fixed by #2684
Assignees

Comments

@antonymilne
Copy link
Contributor

antonymilne commented Apr 17, 2023

Note. Technically this is non-breaking, but best to do this following #2426, which is a breaking change. Hence this is for 0.19.0.

We are removing logging.yml from the project template (see #2281). However, there's a subtle piece of functionality that exists in project-side logging.yml that's not easily reproduced in the framework-side one: the project-side logging.yml has something like this:

loggers:
  kedro:
    level: INFO

  iris:
    level: INFO

It's not possible to put this in the framework-side logging.yml because you don't know what the project name is there. We can achieve this by adding it in the Python code in framework/project/__init__.py though by using PACKAGE_NAME (defined in configure_project), something like this:

logging_config["loggers"].append(PACKAGE_NAME: {"level": "INFO"})

Originally posted by @AntonyMilneQB in #2281 (comment)

@astrojuanlu
Copy link
Member

Closed by gh-2684!

@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants