Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notice for TemplatedConfigLoader and ConfigLoader in the documentation #2900

Closed
ankatiyar opened this issue Aug 7, 2023 · 0 comments · Fixed by #2991
Closed
Assignees
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation

Comments

@ankatiyar
Copy link
Contributor

ankatiyar commented Aug 7, 2023

          > The example look good to me. One comment about the structure of this note, should we place OmegaConfigLoader before TemplatedConfigLoader? I think we should recommend omegaconf for templated value

We can do a separate ticket for moving the section for TemplatedConfigLoader below OmegaConfigLoader and perhaps adding Deprecation notice in the docs for both ConfigLoader and TemplatedConfigLoader. What do you think?

Originally posted by @ankatiyar in #2896 (comment)

To do :

@ankatiyar ankatiyar added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Aug 7, 2023
@merelcht merelcht moved this to To Do in Kedro Framework Aug 18, 2023
@lrcouto lrcouto moved this from To Do to In Progress in Kedro Framework Aug 22, 2023
@lrcouto lrcouto moved this from In Progress to In Review in Kedro Framework Sep 1, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants