-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataCatalog]: Save/load catalog obtained from to_config
#4330
Comments
Do we really need this? This would add extra method and it is unclear to me that we want to specify a specific serialization formation. If we implement I don't have a preference for the serialization format, because I think it would depend on the use case : mlflow will likely force me to use |
The idea is to be able to save/load serialized config, so one can reuse it when running a pipeline. In other words, make it work when using kedro as a framework with It won't be part of the catalog API as like you mentioned we should not force any specific format or various formats at the catalog level. So we consider extending config loader to handle that. |
After the discussion with @idanov we decided not to proceed with it for now as the value of it is not clear. We expect people to keep using original configuration for |
Description
Implement a method to save and load catalog obtained from
KedroDataCatalog.to_config()
- #4330, so it could be used when running kedro project withkedro run.
It won't be part of the catalog API, as we should not force any specific saving/loading formats at the catalog level. So, we consider extending the config loader to handle that.
Blocked by #4326 and #4327
Context
#3932
Possible Implementation
Extend
OmegaConfigLoader
to save and load config obtained fromKedroDataCatalog.to_config()
versioned
flag and dataset parameter #4326 and Discrepancy between settingsave_version
via catalog constructor and when passing datasets #4327versioned
flag and make version part of the dataset config / keep both options / do nothing;save
forOmegaConfigLoader
OmegaConfigLoader.__getitem__
to load files obtained fromKedroDataCatalog.to_config()
. Currently it outputs four dictionaries:catalog
,credetials
andload_versions
,save_versions
. Depending on how we solve step 1 - the output can change.The text was updated successfully, but these errors were encountered: