Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the flakiness of the unit tests failing during nightly builds #4356

Open
ElenaKhaustova opened this issue Nov 29, 2024 · 2 comments · Fixed by #4419
Open

Investigate the flakiness of the unit tests failing during nightly builds #4356

ElenaKhaustova opened this issue Nov 29, 2024 · 2 comments · Fixed by #4419
Assignees
Labels
Component: DevOps Issue/PR that addresses automation, CI, GitHub setup Component: Testing Issue/PR that addresses tests

Comments

@ElenaKhaustova
Copy link
Contributor

Description

#4348
#4349

Specific unit tests are constantly failing during the nightly builds which is usually fixed by several re-run attempts. For example:
tests/framework/session/test_session_extension_hooks.py::TestNodeHooks::test_on_node_error_hook_parallel_runner

We suggest investigating why it's happening, making sure these tests are relevant and consider replacing them to avoid undefined behaviour.

Context

It slows down the development and takes extra time for manual re-runs when wizarding.

@ElenaKhaustova ElenaKhaustova added Component: DevOps Issue/PR that addresses automation, CI, GitHub setup Component: Testing Issue/PR that addresses tests labels Nov 29, 2024
@astrojuanlu
Copy link
Member

Example: https://github.com/kedro-org/kedro/actions/runs/11991462849/job/33430083296

Unclear if this can be reproduced locally or just happens on CI

@merelcht merelcht moved this to To Do in Kedro Framework Jan 13, 2025
@merelcht merelcht self-assigned this Jan 15, 2025
@merelcht merelcht moved this from To Do to In Review in Kedro Framework Jan 15, 2025
@merelcht merelcht linked a pull request Jan 15, 2025 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro Framework Jan 16, 2025
@merelcht
Copy link
Member

Will monitor builds first before determining this is done.

@merelcht merelcht reopened this Jan 16, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Kedro Framework Jan 16, 2025
@merelcht merelcht moved this from In Progress to In Review in Kedro Framework Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: DevOps Issue/PR that addresses automation, CI, GitHub setup Component: Testing Issue/PR that addresses tests
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants