Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube] Remove superfluous custom bytecode listings from kube deployment scripts #15

Open
sdorr0 opened this issue Feb 15, 2024 · 0 comments
Assignees

Comments

@sdorr0
Copy link
Contributor

sdorr0 commented Feb 15, 2024

The current kustomization-template.yml file includes a kappa-config entry for custom bytecode:

configMapGenerator:
  - name: kappa-config
    literals:
      - capture=__CAPTURE__
      - device=__CLUSTER__
      - region=__REGION__
      - plan=__PLAN__
      - bytecode=x86_64/kappa_bpf-ubuntu-5.4.o

This bytecode option is largely superfluous at this point as, to date, no clients are running linux systems with old enough kernels to require custom bytecode and the likelihood of getting a new client with a pre-5.8 kernel is exceedingly unlikely, SE's have reported that this entry is a source of confusion for customers.

Let's remove this entry, test to make sure deploys are still functional without it, and update the kentik-kube-deploy repo. In the unlikely event a customer requires it, SE's can instruct a client with the proper .yml config additions to include custom byte code.

@sdorr0 sdorr0 self-assigned this Feb 15, 2024
@sdorr0 sdorr0 changed the title Remove superfluous custom bytecode listings from kube deployment scripts [kube] Remove superfluous custom bytecode listings from kube deployment scripts Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant