Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock time out can be too short #2

Open
geoffroy-noel-ddh opened this issue Oct 29, 2024 · 0 comments
Open

Lock time out can be too short #2

geoffroy-noel-ddh opened this issue Oct 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@geoffroy-noel-ddh
Copy link
Member

On CPU processing 10+ questions with moondream can easily last much longer than the time out on the lock in the answer file.

This means that a second instance can start processing the same image as the first one. And continue to do so over the rest of the collection. Essentially making the second instance useless and wasting resources.

Option 1: Increasing the time out

Doing so can be annoying during testing phase, when forced interruption and quick retry are frequent. Also there is never a guarantee that an arbitrary duration will very be enough.

Option 2: Locker keeps updating the time while processing

Approach is more sound. But it is difficult to implement because bvqa sends all the questions at once to the describer. The describer only returns when all completed. So we either need:

  • an answer callback (if the describer allows it)
  • or a separate thread in bvqa to keep updating the time while waiting for the describer to return
@geoffroy-noel-ddh geoffroy-noel-ddh self-assigned this Oct 29, 2024
@geoffroy-noel-ddh geoffroy-noel-ddh added the bug Something isn't working label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant