Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failed in MvxRecyclerView #1

Open
alexshikov opened this issue Mar 19, 2015 · 7 comments
Open

Compilation failed in MvxRecyclerView #1

alexshikov opened this issue Mar 19, 2015 · 7 comments

Comments

@alexshikov
Copy link

Views/MvxRecyclerView.cs(28,44): error CS0533: MvxAndroid.Support.V7.AppCompat.Views.MvxRecyclerView.Adapter' hides inherited abstract memberAndroid.Support.V7.Widget.RecyclerView.Adapter'

The next property is reason of error:

public new IMvxRecyclerViewAdapter Adapter
{...}

There is an internal abstract class public abstract class Adapter {}

As a temporary solution I decided to rename property to MvxAdapter.

Any hints on this?

@kjeremy
Copy link
Owner

kjeremy commented Mar 19, 2015

I'm not getting this error, it's just a warning for me. Most of the Mvx
widgets (MvxListView for instance) do the same thing.

On Thu, Mar 19, 2015 at 3:45 PM, Alexey Shikov [email protected]
wrote:

Views/MvxRecyclerView.cs(28,44): error CS0533: MvxAndroid.Support.V7.AppCompat.Views.MvxRecyclerView.Adapter'
hides inherited abstract member
Android.Support.V7.Widget.RecyclerView.Adapter'

public new IMvxRecyclerViewAdapter Adapter
{...}

There is an internal abstract class public abstract class Adapter {}

As a temporary solution I decided to rename property to MvxAdapter.

Any hints on this?


Reply to this email directly or view it on GitHub
#1.

@alexshikov
Copy link
Author

Let's start from check our basic environments:
I'm using Xamarin Studio on Mac.
Are you?

@kjeremy
Copy link
Owner

kjeremy commented Mar 19, 2015

I'm using Visual Studio. Do have "Treat warnings as errors" checked in the
Project Options (Compiler)? That would do it, but again it's only a
warning. You can still use the RecyclerView.Adapter class if you want to.

On Thu, Mar 19, 2015 at 3:59 PM, Alexey Shikov [email protected]
wrote:

Let's start from check our basic environments:
I'm using Xamarin Studio on Mac.
Are you?


Reply to this email directly or view it on GitHub
#1 (comment)
.

@alexshikov
Copy link
Author

This checkbox is turned off for me (that means Warning are not treated as errors).
So Xamarin Studio treats this issue as true error.

I don't really need any of these (property or internal class) yet. Just to compile the code.

Seems have to leave renamed variable as temporary solution.

@kjeremy
Copy link
Owner

kjeremy commented Mar 20, 2015

I can compile using Xamarin Studio on a PC so it must be an issue with mono.

I filed a bug https://bugzilla.xamarin.com/show_bug.cgi?id=28213

@kjeremy
Copy link
Owner

kjeremy commented Mar 26, 2015

They just marked this as fixed in mono master so hopefully we'll get it on the next build

@alexshikov
Copy link
Author

Yeah, I saw. Great news!
Let's keep this ticket open until new version be available in Stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants