Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

dev(SSJ): use OZ contracts #1521

Open
obatirou opened this issue Oct 21, 2024 · 5 comments
Open

dev(SSJ): use OZ contracts #1521

obatirou opened this issue Oct 21, 2024 · 5 comments
Assignees

Comments

@obatirou
Copy link
Collaborator

Remove custom implementation (ownable and upgradeable) that were copy from OZ and add the OZ contract dependencies.

@manlikeHB
Copy link

Hi @obatirou, can I work on this?

@ClementWalter
Copy link
Member

hey @manlikeHB sure, I assigned you

@ClementWalter ClementWalter moved this from 🆕 Backlog to 🧑‍💻 Open contributor in Kakarot on Starknet Oct 25, 2024
@manlikeHB
Copy link

Hi @ClementWalter, I realized SSJ contains a custom openzeppelin package which contains an ERC20 contract. Adding the the OZ dependency will cause a clash between the two.

Should I proceed to removing the custom openzeppelin package and use OZ's component for the ERC20 contract?

@obatirou
Copy link
Collaborator Author

Hi @ClementWalter, I realized SSJ contains a custom openzeppelin package which contains an ERC20 contract. Adding the the OZ dependency will cause a clash between the two.

Should I proceed to removing the custom openzeppelin package and use OZ's component for the ERC20 contract?

Yes, please do so
This is the goal of this issue: remove the custom OZ packages and use the official ones

@manlikeHB manlikeHB mentioned this issue Oct 31, 2024
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: 🧑‍💻 Open contributor
Development

Successfully merging a pull request may close this issue.

4 participants
@ClementWalter @obatirou @manlikeHB and others