Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reported grading error on challenge #2

Open
weaverryan opened this issue Apr 7, 2016 · 3 comments
Open

Reported grading error on challenge #2

weaverryan opened this issue Apr 7, 2016 · 3 comments

Comments

@weaverryan
Copy link
Member

From UserVoice:

knpuniversity.com/screencast/oo-ep3/broken-ship/activity/291

printing any value below 3000 results in failing challenge (Hmm, did you print the DeathStarIII description in h3 tag?) when this value isn't indicated in instructions to challenge

@bocharsky-bw can you look at this? Let me know what you find, and I can update the user :).

@bocharsky-bw
Copy link
Member

Yes, I tweak the grading in ed51c56 . Now user can return any number :)

I'm wondering how to deploy changes to prod?

@weaverryan
Copy link
Member Author

@bocharsky-bw awesome! What was the significance of 3000 - is that some value that is in the class by default? Right now, to deploy, when you edit the oo-ep3 screencast in the admin area, there is a textbox at the bottom called Challenges repository sha - update that to the new sha on this repository and it will update :). I'll let you do make that change :).

Thanks!

@bocharsky-bw
Copy link
Member

3000 was our hardcoded value at solution step, but I missed that fact that user can enter another value. That's why my grading failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants