Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swaps in Gallery Item follow up #11213

Open
hassnian opened this issue Dec 5, 2024 · 3 comments
Open

Swaps in Gallery Item follow up #11213

hassnian opened this issue Dec 5, 2024 · 3 comments
Labels
A-atomic-swap p2 core functionality, or is affecting 60% of app UX first Improvement for UX

Comments

@hassnian
Copy link
Contributor

hassnian commented Dec 5, 2024

missing action button, closed by #11228

CleanShot 2024-12-05 at 08 30 49@2x

Swap Table

  • show surcharge direction and amount if there is enough space

image

@hassnian hassnian changed the title Swap in Gallery Item Swaps in Gallery Item Dec 5, 2024
@hassnian hassnian added the UX first Improvement for UX label Dec 5, 2024
@hassnian hassnian changed the title Swaps in Gallery Item Swaps in Gallery Item follow up Dec 5, 2024
@exezbcz
Copy link
Member

exezbcz commented Dec 9, 2024

image

lets put it next to the offer button

please make the buy button with the cart button the same width so it is visually aligned

  • that means that the cart button will be wider to a width of the "swap" part of the button

updated in: https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=9007-36740&node-type=canvas&t=7YKPyslKxVUPfoGc-11

@exezbcz exezbcz added p2 core functionality, or is affecting 60% of app and removed design-request labels Dec 9, 2024
@exezbcz
Copy link
Member

exezbcz commented Dec 9, 2024

It will redirect you to the swap page with the item preselected. The user will then only need to specify if they want to add any additional tokens and select the items they wish to offer.

@exezbcz
Copy link
Member

exezbcz commented Dec 9, 2024

will add the activity tab small info soon

@hassnian hassnian self-assigned this Dec 10, 2024
@hassnian hassnian removed their assignment Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-atomic-swap p2 core functionality, or is affecting 60% of app UX first Improvement for UX
Projects
None yet
Development

No branches or pull requests

2 participants