Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Time proto functions #29

Open
vrom911 opened this issue Sep 26, 2019 · 0 comments
Open

[RFC] Time proto functions #29

vrom911 opened this issue Sep 26, 2019 · 0 comments
Labels
question Further information is requested

Comments

@vrom911
Copy link
Member

vrom911 commented Sep 26, 2019 •
edited
Loading

Pros:

  • no need to implement then in every project
  • they are universal

Cons:

  • Huge dependency — proto-lens as it defined HasField inside
  • Need to create a lot of lenses
  • The type constrains will look scary
  • Proto files still should be copied in every project
@vrom911 vrom911 added the question Further information is requested label Sep 26, 2019
@vrom911 vrom911 mentioned this issue Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vrom911