-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace JWT session management with Cookies #50
Comments
@jonathanjouty Thanks for your kind words about the project! Could you please, clarify more on the issues with using JWT? I've read various posts on JWT and GitHub discussion, but I didn't notice any problems with JWT in our case, and I also didn't found any viable alternatives. Also, all explanations on why JWT are bad are quite vague. For example, what can be wrong if we store |
Hey, sorry for taking so long to get back to this.
From what I understand, in That is a problem in itself! I've now (re) found the articles that explain this really well:
From [1] above:
Here "sessions" means server-side stateful sessions, almost always implemented using cookies (following OWASP best practices). Facebook, Google, Reddit, GitHub... everyone uses them!
The post [1] above goes into specifics very nicely, I should have linked to that originally. Hopefully this provides sufficient information. |
@chshersh did my explanation help or further confuse things? |
@jonathanjouty Thanks for your reply and time to write the answer! I appreciate that 👍 Sorry, we didn't have time to look into this JWT issue, since we've been busy with other stuff. But I have this issue in my bookmarks on GitHub and I have plans to return back to it and study the problem carefully 🙂 |
This issue was in my bookmarks for a long time... I've researched the User Authentication and Session Management topics thoroughly, and cookies indeed seem like a better option. We will update the architecture once we have enough time for it 🙂 |
Let me start by saying that this project is really cool and inspirational!
Thanks for working on it and putting it out there.
On a recent project I started out by using JWTs as API tokens, but after some research discovered that it really is not a good idea.
They have their use-case, but not as API tokens or client sessions.
See Thomas Ptacek's comment on JWTs, and this long discussion.
The tl;dr is:
The text was updated successfully, but these errors were encountered: