Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input JSON needs to be populated with label information of the pods in the metrics section #512

Closed
bharathappali opened this issue Sep 23, 2022 · 1 comment
Labels
EM Experiment Manager related issues enhancement New feature or request

Comments

@bharathappali
Copy link
Member

To extract the pod name, instead of selecting the pod based on searching container name and deployment name it would be easier to have the key and value of the labels associated to the pods to retrieve its name.

The kubernetes client abstraction already has the getPodsBy (namespace, labelKey, labelValue) so we could call the function to get pod details which has name in it.

The workaround we could do for now is to search all pods whose metadata matches the deployment name and has the container name provided in the input JSON.

We cannot assume the label will always be app=<deployment_name> so it would be better to get this information from the user

@bharathappali bharathappali added enhancement New feature or request EM Experiment Manager related issues labels Sep 23, 2022
@bharathappali
Copy link
Member Author

No longer a priority. Will re-open if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EM Experiment Manager related issues enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant