Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google Artifact Registry #115

Open
vijaytdh opened this issue Jan 10, 2025 · 0 comments
Open

Support Google Artifact Registry #115

vijaytdh opened this issue Jan 10, 2025 · 0 comments

Comments

@vijaytdh
Copy link

The kubescape operator components don't seem to be able to pull images from Google Artifact Registry. Looking at the code it uses this package https://github.com/kubescape/k8s-interface/blob/main/cloudsupport/cloudvendorregistrycreds.go#L198

But the function below only supports registry URLs that start with "gcr.io"

func CheckIsGCRImage(imageTag string) bool {
	// gcr.io/elated-pottery-310110/golang-inf:2
	return strings.Contains(imageTag, "gcr.io/")
}

This would need to be changed to something like:

func CheckIsGCRImage(imageTag string) bool {
	// gcr.io/elated-pottery-310110/golang-inf:2
	return strings.Contains(imageTag, "gcr.io/") || strings.Contains(imageTag, ".pkg.dev/")
}

Or use some sort of regex.

The only workaround I can think of is to have try to have pull secrets but that's not convenient to have to manage secrets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant