Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop,Mobile: Plugins: Legacy editor API: Fix delayed crash caused by out-of-bounds inputs #11714

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Desktop,Mobile: Plugins: Legacy editor API: Fix delayed crash caused by out-of-bounds inputs #11714

wants to merge 2 commits into from

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 23, 2025 •
edited
Loading

Summary

This pull request makes two changes:

This change may resolve #11710.

Manual regression testing

In addition to running the automated tests, I've verified that the Rich Markdown plugin (which uses the legacy API) can still:

  • Render images (for images on their own line).
  • Fade Markdown elements on other lines (e.g. header # characters).
  • Render highlighted text (e.g. ==test==).

@personalizedrefrigerator personalizedrefrigerator mentioned this pull request Jan 23, 2025
Open
@personalizedrefrigerator personalizedrefrigerator added editor plugins Anything related to Joplin's plugin system labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
editor plugins Anything related to Joplin's plugin system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal Crash "Position 1325 is out of range for changeset of length 1324" after strange Cursor behaviour
1 participant
@personalizedrefrigerator