Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for envrionment variables #9

Open
jjcollinge opened this issue Dec 5, 2017 · 4 comments
Open

Add fallback for envrionment variables #9

jjcollinge opened this issue Dec 5, 2017 · 4 comments

Comments

@jjcollinge
Copy link
Collaborator

If the parameters are not found via flaeg, fallback and check environment variables - this will allow users to override environment variables in isolated environment specific parameters files without having to embed them in the ServiceManifest.xml. This will help avoid having the appinsights key checked into source control and support multiple environments.

@lawrencegripper
Copy link
Owner

lawrencegripper commented Dec 6, 2017

Would this be something we could PR into flaeg rather than implement here?

@serbrech
Copy link
Contributor

serbrech commented Dec 6, 2017

I don't think that fits flaeg. Flaeg does 1 thing : parse command line arguments. Handling multiple configuration sources sounds like another layer that could use flaeg.
In fact I think Containous built exactly that : https://github.com/containous/staert
except it doesnt support environment variable... yet :)

Three native sources :
Command line arguments using flæg package
TOML config file using toml package
Key-Value Store using libkv and mapstructure packages
An Interface to add your own sources

I can spike that if you guys agree.

@serbrech
Copy link
Contributor

serbrech commented Dec 6, 2017

linking to the request : containous/staert#35

@jjcollinge
Copy link
Collaborator Author

Nice find @serbrech - would be great if we picked up that PR and finished of the work - assuming we're most of the way there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants