Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase accounts access from 5 to 10 for Ledger #4983

Closed
cuevasm opened this issue Feb 26, 2024 · 3 comments · Fixed by #5345
Closed

Increase accounts access from 5 to 10 for Ledger #4983

cuevasm opened this issue Feb 26, 2024 · 3 comments · Fixed by #5345
Assignees
@alter-eggo
Labels
area:accounts area:ledger effort:small Expected to take up to 1 day of integration work enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives

Comments

@cuevasm
Copy link

cuevasm commented Feb 26, 2024 •
edited
Loading

Very strange issue. I have one wallet setup without a Ledger, on another computer I have one setup with a Ledger. In one interface I'm given the option to create another account as expected: https://leather.gitbook.io/guides/accounts/how-do-additional-accounts-work-in-leather

In the Ledger one, this area is blank (no create new account button). I've tried connecting/disconnecting, etc. Can't do anything to give me the option to setup another account. In both instances, I am running the latest Windows, latest Chrome, latest version of the extension.

unnamed (3)
@markmhendrickson
Copy link
Collaborator

This is due to #2502

@kyranjamie would it be much work to hardcode 10 rather than just 5, until we make this extensible as part of our upcoming accounts UX redesign work?

@kyranjamie
Copy link
Collaborator

Sure. Trivial change.

@markmhendrickson markmhendrickson changed the title No ability to create new account Increase accounts access from 5 to 10 for Ledger Feb 26, 2024
@markmhendrickson markmhendrickson added enhancement-p2 Critical functionality needed by few users, with no clear alternatives area:accounts area:ledger enhancement labels Feb 26, 2024
@alter-eggo alter-eggo added the effort:small Expected to take up to 1 day of integration work label May 1, 2024
@kyranjamie
Copy link
Collaborator

Closed by #5345

@fbwoolf fbwoolf linked a pull request May 7, 2024 that will close this issue
fix: change default to pulling 10 keys #5345
Merged
pete-watters added a commit that referenced this issue May 15, 2024
@pete-watters
fix: show correct UI count for BTC addresses being pulled, ref #4983
910a39d
github-merge-queue bot pushed a commit that referenced this issue May 15, 2024
@pete-watters
fix: show correct UI count for BTC addresses being pulled, ref #4983
9f73b24
kyranjamie pushed a commit that referenced this issue May 17, 2024
@semantic-release-bot
chore(release): 6.40.0
d9894a4 
## [6.40.0](v6.39.0...v6.40.0) (2024-05-17)

### Features

* add link in swaps disabled tooltip ([93f8964](93f8964))
* enable btc retrieval, closes [#5067](#5067) ([92d9603](92d9603))

### Bug Fixes

* brc20 sends software only ([4983476](4983476))
* go back properly and don't allow user to close non cancellable ledger actions, closes [#5143](#5143) ([c28342b](c28342b))
* **ledger:** use correct key number ([56100bf](56100bf))
* only decorate psbt inputs without an existing nonWitnessUtxo ([d47f87b](d47f87b))
* show correct amount for nonWitnessUtxo, ref [#5113](#5113) ([65a4f52](65a4f52))
* show correct UI count for BTC addresses being pulled, ref [#4983](#4983) ([9f73b24](9f73b24))
* utxos and transaction request cancellation, closes [#5058](#5058) ([ae1b04b](ae1b04b))

### Internal

* add backgroundLocation for device busy step ([e288d41](e288d41))
* assets and asset list ([88939cc](88939cc))
* btc balance ([bbc43d6](bbc43d6))
* post-release merge back ([61b8171](61b8171))
* refactor canclose ([d275ad7](d275ad7))
* stx balance ([4e3190f](4e3190f))
* temporarily disable swaps feature ([e34d5f3](e34d5f3))
* update packages ([c685b10](c685b10))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alter-eggo alter-eggo

Labels
area:accounts area:ledger effort:small Expected to take up to 1 day of integration work enhancement enhancement-p2 Critical functionality needed by few users, with no clear alternatives
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change default to pulling 10 keys leather-io/extension
4 participants
@markmhendrickson @kyranjamie @cuevasm @alter-eggo