Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit snippet.description.length #136

Open
kyoshizaki opened this issue Jun 7, 2018 · 0 comments
Open

Limit snippet.description.length #136

kyoshizaki opened this issue Jun 7, 2018 · 0 comments
Milestone

Comments

@kyoshizaki
Copy link
Member

kyoshizaki commented Jun 7, 2018

Description length limit for table column

  • migration file: t.text
  • maria db: text => 65,535

Description length limit for model

source_type: direct

  • category: text / header / subheader
  • description: text of the snippet
  • limit: USER_TEXT_LENGTH => SNIPPET_MAX_LENGTH
    • constant rename and before_save callback

source_type: page

  • category: text
  • description: text of the snippet
  • limit: (none) => SNIPPET_MAX_LENGTH
    • before_save callback

source_type: upload

  • category: image
  • description: NULL

source_type: web

  • category: text
    • description: text of the snippet
    • limit: WEB_SNIPPET_MAX_LENGTH
  • category: pdf
    • description: text of the snippet
    • limit: (none) => SNIPPET_MAX_LENGTH
    • remarks: SHOULD BE WEB_SNIPPET_MAX_LENGTH and WILL BE CHANGED after 1st semester of 2018
  • category: image
    • description: URL
    • limit: (none)
    • remarks: this should be stored in other table/column and make all snippet.description.length <= SNIPPET_MAX_LENGTH
  • category: scratch / ted / youtube
    • description: ''
@kyoshizaki kyoshizaki changed the title Limit snippet.description.length for PDF Limit snippet.description.length Jun 7, 2018
kyoshizaki added a commit that referenced this issue Jun 7, 2018
@kyoshizaki kyoshizaki added this to the v0.4 milestone Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant