Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically configure Guice modules for langtorch hub based on the config file #138

Open
li2109 opened this issue Jun 18, 2023 · 3 comments
Assignees
Labels

Comments

@li2109
Copy link
Owner

li2109 commented Jun 18, 2023

No description provided.

@li2109 li2109 added the feature label Jun 18, 2023
@rubio-He
Copy link
Contributor

I can work on this if you didn't start working on it yet.

@li2109
Copy link
Owner Author

li2109 commented Jun 18, 2023

I can work on this if you didn't start working on it yet.

I think the goal is to install corresponding guice modules based on the config file.
It's better to make a generic class that does this.

For example:
A registry that we can bind a flag to a module
A reader that reads the config and adds corresponding modules based on the config and modules in the registry?

@li2109 li2109 assigned li2109 and rubio-He and unassigned li2109 Jun 18, 2023
@rubio-He
Copy link
Contributor

I can work on this if you didn't start working on it yet.

I think the goal is to install corresponding guice modules based on the config file. It's better to make a generic class that does this.

For example: A registry that we can bind a flag to a module A reader that reads the config and adds corresponding modules based on the config and modules in the registry?

Thank you for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants