-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
definition of strain #12
Comments
I agree that the name Delta+epsilon is confusing because it suggests small strain. It should probably be called deformation gradient. However, I think conversion to Green-Lagrangian strain should be up to the user - but adding a function that returns that would probably be useful.
…---
Prof. Lars Pastewka
University of Freiburg
Department of Microsystems Engineering
Office: +49 761 203-67480
http://www.imtek.de/laboratories/simulation
________________________________
Von: gabor1 <[email protected]>
Gesendet: Freitag, 20. Juli 2018 16:48
An: libAtoms/matscipy
Cc: Subscribed
Betreff: [libAtoms/matscipy] definition of strain (#12)
hi Guys!
Vikram and I were reviewing the code in get_delta_plus_epsilon(), because we wanted to understand exactly what was being calculated. Here are some suggestions:
1. you compute the deformation matrix, which is indeed delta+epsilon, as suggested by the name of the function, but then the name of the variable into which it is accumulated is just called epsilon, which is confusing.
2. The deformation matrix that is thus computed is not symmetric, so can include rotations. we suggest to take those out, using M.T*M
3. To actually get a strain, one has to subtract the identity, so we suggest that is done, so the final thing returned should be 0.5 (M.TM - I) where M is the thing accumulated in get_delta_plus_epsilon()
-
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#12>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACacVwifqsZBvAs4wcCVFU7HdyuEc9hEks5uIe2YgaJpZM4VYKI6>.
|
Sure. Perhaps also rename the function to atomic_deformation_gradient?
…-- Gábor
On 21 Jul 2018, at 09:29, Lars Pastewka ***@***.***> wrote:
I agree that the name Delta+epsilon is confusing because it suggests small strain. It should probably be called deformation gradient. However, I think conversion to Green-Lagrangian strain should be up to the user - but adding a function that returns that would probably be useful.
---
Prof. Lars Pastewka
University of Freiburg
Department of Microsystems Engineering
Office: +49 761 203-67480
http://www.imtek.de/laboratories/simulation
________________________________
Von: gabor1 ***@***.***>
Gesendet: Freitag, 20. Juli 2018 16:48
An: libAtoms/matscipy
Cc: Subscribed
Betreff: [libAtoms/matscipy] definition of strain (#12)
hi Guys!
Vikram and I were reviewing the code in get_delta_plus_epsilon(), because we wanted to understand exactly what was being calculated. Here are some suggestions:
1. you compute the deformation matrix, which is indeed delta+epsilon, as suggested by the name of the function, but then the name of the variable into which it is accumulated is just called epsilon, which is confusing.
2. The deformation matrix that is thus computed is not symmetric, so can include rotations. we suggest to take those out, using M.T*M
3. To actually get a strain, one has to subtract the identity, so we suggest that is done, so the final thing returned should be 0.5 (M.TM - I) where M is the thing accumulated in get_delta_plus_epsilon()
-
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#12>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACacVwifqsZBvAs4wcCVFU7HdyuEc9hEks5uIe2YgaJpZM4VYKI6>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hi Guys!
Vikram and I were reviewing the code in get_delta_plus_epsilon(), because we wanted to understand exactly what was being calculated. Here are some suggestions:
you compute the deformation matrix, which is indeed delta+epsilon, as suggested by the name of the function, but then the name of the variable into which it is accumulated is just called epsilon, which is confusing.
The deformation matrix that is thus computed is not symmetric, so can include rotations. we suggest to take those out, using M.T*M
To actually get a strain, one has to subtract the identity, so we suggest that is done, so the final thing returned should be 0.5 (M.TM - I) where M is the thing accumulated in get_delta_plus_epsilon()
The text was updated successfully, but these errors were encountered: