Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove project.Makefile #97

Closed
noelmcloughlin opened this issue Feb 2, 2024 · 3 comments
Closed

remove project.Makefile #97

noelmcloughlin opened this issue Feb 2, 2024 · 3 comments

Comments

@noelmcloughlin
Copy link
Contributor

noelmcloughlin commented Feb 2, 2024

I think project.Makefile (included by Makefile) could be removed.
I suspect most users ignore it, and removal helps cleanup workspace.

@matentzn
Copy link
Contributor

matentzn commented Feb 2, 2024

I personally do not agree - we use it in SSSOM for example for test file validation, and there we plan to use it also for things like generating documentation pages eg https://github.com/monarch-initiative/monarch-documentation/blob/main/project.Makefile#L15

@noelmcloughlin
Copy link
Contributor Author

Wow, did not realize some users are very technical to use the feature.

I'll update #57 (comment) with your link to say needs consideration. thanks.

@matentzn
Copy link
Contributor

matentzn commented Feb 2, 2024

Thanks @noelmcloughlin - I have to admit that I am using Makefiles a lot, and this specific pattern, having a root Makefile that is managed by the project template and a project.Makefile that is used to extend the content of the Makefile (and, in some cases, overwriting it, we use a lot in frameworks like the Ontology Development Kit, see, eg. here:

https://github.com/obophenotype/human-phenotype-ontology/blob/3a4062111bc683b9c9d1e126eb62a6ed5e44ad28/src/ontology/Makefile#L840

So we inherit all variables, all goals etc, and overwrite or extend what is necessary. Sometimes, if we see the same code being extended in many different projects (multi language support is an example from the ontology world, or the use of design patterns) we extend the Makefile to supply this feature to everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants