Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for names #50

Closed
uselessgoddess opened this issue Sep 21, 2021 · 2 comments · Fixed by #54 or #55
Closed

Suggestion for names #50

uselessgoddess opened this issue Sep 21, 2021 · 2 comments · Fixed by #54 or #55

Comments

@uselessgoddess
Copy link
Member

uselessgoddess commented Sep 21, 2021 •
edited
Loading

Rename to RunAsRead

Threading/csharp/Platform.Threading/Synchronization/ISynchronization.cs

Line 18 in dc8454f

void ExecuteReadOperation(Action action);

Rename to RunAsWrite

Threading/csharp/Platform.Threading/Synchronization/ISynchronization.cs

Line 36 in dc8454f

void ExecuteWriteOperation(Action action);

Rename to more neutral PushAndRun

Threading/csharp/Platform.Threading/ConcurrentQueueExtensions.cs

Line 52 in dc8454f

public static void EnqueueAsRunnedTask(this ConcurrentQueue<Task> queue, Action action) => queue.Enqueue(Task.Run(action));

@uselessgoddess uselessgoddess pinned this issue Sep 21, 2021
@Konard
Copy link
Member

Konard commented Sep 21, 2021

  • RunAsRead
  • RunAsWrite
  • RunAndPush

@uselessgoddess
Copy link
Member Author

Updated

This was linked to pull requests Dec 22, 2021
Rename methods #54
Merged
Rename methods #55
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename methods linksplatform/Threading
Rename methods linksplatform/Threading
2 participants
@Konard @uselessgoddess