Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Node selector, Affinity & Tolerations support for virtual-kubelet deployment #1775

Open
Sharathmk99 opened this issue Apr 11, 2023 · 2 comments
Open

[Feature] Node selector, Affinity & Tolerations support for virtual-kubelet deployment #1775

Sharathmk99 opened this issue Apr 11, 2023 · 2 comments
Labels
feat Adds a new feature to the codebase

Comments

@Sharathmk99
Copy link
Contributor

Is your feature request related to a problem? Please describe.

With ticket #1755 nodeSelector, affinity & tolerations is support by helm chart. But virtual-kubelet created by liqo controller doesn't support the same.
This is needed when cluster has dedicated nodes for services which are tainted

Describe the solution you'd like
Need to update controller to support the same

Describe alternatives you've considered
Using without nodeSelector, affinity & tolerations

Additional context
Add any other context or screenshots about the feature request here.
@cheina97 cheina97 closed this as completed May 2, 2023
@Sharathmk99
Copy link
Contributor Author

@cheina97 This feature is not yet implemented. Changes were made only to Helm chart not controller. Can we reopen this issue?

@cheina97
Copy link
Member

cheina97 commented May 7, 2023

Of course. Sorry for the inconvenience.

@cheina97 cheina97 reopened this May 7, 2023
@aleoli aleoli added the feat Adds a new feature to the codebase label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat Adds a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Sharathmk99 @cheina97 @aleoli