Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate file handle from pike.Handle. #8

Open
lithdew opened this issue Nov 19, 2020 · 0 comments
Open

Separate file handle from pike.Handle. #8

lithdew opened this issue Nov 19, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@lithdew
Copy link
Owner

lithdew commented Nov 19, 2020

Sockets on Windows are represented by a ws2_32.SOCKET, unlike generic file handles which are represented by windows.HANDLE.

To cleanup all the verbose @ptrCast(ws2_32.SOCKET, self.handle.inner) casts in socket_windows.zig, it would be ideal to separate the file handle from pike.Handle.

Doing so would also allow removing unnecessary fields, such as async types that do not require a file handle (e.g. signal_posix.zig).
@lithdew lithdew added the enhancement New feature or request label Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lithdew