Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloaded event maps misaligned? - investigate #1378

Open
phraenquex opened this issue Mar 6, 2024 · 3 comments
Open

Downloaded event maps misaligned? - investigate #1378

phraenquex opened this issue Mar 6, 2024 · 3 comments
Assignees
Labels
2024-03-15 indigo Data dissemination loose ends XChemAlign

Comments

@phraenquex
Copy link
Collaborator

phraenquex commented Mar 6, 2024

For this CHIKV download:

In Fragalysis (NGL), the event maps aligns perfectly with the ligand; but when I download the maps and ligand and display them in pymol, they're offset. Bug in upload/download chain, or pymol weirdness?

@tdudgeon
Copy link
Collaborator

tdudgeon commented Mar 6, 2024

I believe there is an "offset" property that is defined in the maps that handles the periodic boundary problem. This is handled by NGL (see #1238). Presumably this is not handled in pymol and presumably the downloaded files display fine if opened in NGL?

@phraenquex phraenquex added 2023-11-02 yellow Too big for V2 and removed 2023-08-23 violet V2 full release labels Mar 7, 2024
@phraenquex
Copy link
Collaborator Author

Decision to take: do we care about pymol users.

(Conor says coot does use offsets correctly. We don't know about other things, e.g. ChimeraX.)

Minimal action: document correclty in the PDF. #1259.

@mwinokan mwinokan added 2024-03-15 indigo Data dissemination loose ends and removed 2023-11-02 yellow Too big for V2 labels Mar 13, 2024
@mwinokan mwinokan moved this to ASAP critical in Fragalysis May 29, 2024
@mwinokan
Copy link
Collaborator

mwinokan commented Jun 3, 2024

From Daren:

Caught up with Conor and he pointed out NGL viewer uses origins in map file but Pymol and Coot don't which fits with what I've seen with Jasmin's data. So we believe the files being served up are indeed the same as those being displayed.

I think the vast majority of users will be using Pymol/Coot and Conor said it's feasible for him to create multiple map files as suggested (i'm guessing we just need 2) so can we go ahead and create a ticket for that?

Event maps in the NGL viewer and download are the same, but when viewed with PyMol/Coot they are offset as the origins are not used.

@ConorFWild please see #1448 for the changes needed to XCA

@mwinokan mwinokan moved this from ASAP critical to In production (Done) in Fragalysis Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-03-15 indigo Data dissemination loose ends XChemAlign
Projects
Status: In production (Done)
Development

No branches or pull requests

4 participants