[Issue] Delay Dry/Wet wrong behaviour

[Ar-Ess]

Problem:
Dry channel of the delay effects wet channel.

Expected behaviour:
As the audio engeneering concept implies, Dry & Wet must be two signals apart, totally independent, where Dry controls the volume of the sound without effect, and Wet controls the volume of the sound with effect. So if Dry volume is at 0 & Wet volume al 1, the wet channel should still sound (in this effect case, just the delayed sound).
In this miniaudio version, if Dry channel is at 0.5, wet channel starts at 0.5 of volume. So there is no way to acquire just the wet signal alone.

Additional Information:
This issue happens on the delay effect in Windows version (C++). I don't know wether it happens on other effects.

In the case this feature is stablished like this on purpose, I suggest renaming the "Dry" variable inside the ma_delay_node because it can lead to confusions about the usual behaviour of those components in audio engeneering. For example, "delayVolume" descrives better what "dry" value does inside ma_delay_node. Apart, I would suggest adding the feature of "Dry" as well, in case someone just wants the "Wet" signal alone (which is my case).

If anything of the commented above is wrong in terms of miniaudio.h code, feel free to correct me.

[mackron]

Thanks. You're absolutely right about this. I just messed that up. Looking at it, I think the wet/dry properties were untested the whole time. Certainly the intent was exactly as you described - to have "knobs" to control how much of the dry and wet signal is heard, with each being independent of each other.

I've updated the logic to look like this, which looks correct to me (and sounds correct to my ear as well). It's in the dev branch.

/* Feedback */
buffer[iBuffer] = input[iInput] + (buffer[iBuffer] * decay);

/* Apply wet and dry factors and output. */
output[iOutput] = (buffer[iBuffer] * wet) + (input[iInput] * dry);

Are you able to give the dev branch a try? I haven't checked other effects just yet, but will need to have a look at those as well at some point.

(Also FYI, in miniaudio all effect stuff is cross platform. The only platform-specific code is the low-level device IO stuff.)

Thanks for reporting this one.

[Ar-Ess]

Okey, I'll eventually have to use all miniaudio effect nodes, so I'll be reporting if this issue repeats.
Apart from that, I'll check as well the development branch and report if the behaviour is now right.
You'll have to give me few days for that (in no more than 3 days I get back to you in this post)

[Ar-Ess]

Okey, I tested the dev branch:
The issue is solved with the new code implementation, but thanks to that I found another issue.
It is difficult to explain, so I'll make a table to organize the issue.

	Falloff > 0	Falloff == 0
Delay dry==0	Dry signal still sounds (issue). I think the problem is that "wet" signal has the initial "sound". In a wet signal, you only have the delayed sound, not the first one.	Works perfectly, this is what your new code implementation solved
Delay dry > 0	The dry signal sounds but not in the ratio inputted in "ma_delay_node_set_dry"(issue). It sounds full volume, as if dry would be 1.0f	The dry signal does not sound anymore (issue). The inicial sound should be listened at the ratio inputed with the function "ma_delay_node_set_dry"