Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little paper cut: hanging #34

Open
brillout opened this issue Sep 25, 2024 · 3 comments
Open

Little paper cut: hanging #34

brillout opened this issue Sep 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@brillout
Copy link

brillout commented Sep 25, 2024

This erroneous usage makes HTTP requests hang.

Not a blocker, just a little paper cut (an error message instead of hanging would be slightly better). It isn't high prio I guess. Feel free to close if polishing isn't a priority at the moment.

Also happens with createMiddleware().

@magne4000
Copy link
Owner

I would like this syntax to work, as the usual usage is kinda weird when the handler does not have any params, but I didn't find a way to have both syntax working. And if want to support middlewares and handlers which accepts options, the former createHandler(...)() syntax is necessary.
However, that's not a big issue because end users usually should not use createHandler directly. But if we find a way to make it work, it would be good.

@brillout
Copy link
Author

that's not a big issue because end users usually should not use createHandler directly

Agreed 👍 Just wanted to let you know.

@magne4000 magne4000 added the enhancement New feature or request label Sep 25, 2024
@brillout
Copy link
Author

brillout commented Dec 2, 2024

Also: #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants