You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, first of all many thanks for developing and open sourcing this! It is much appreciated and we thought we could maybe give something back by helping improve it.
We got caught out by the config specifying odin.yml in two separate places today after noticing it had nuked our UAT stages when we had configured it to not.
The custom variable under odin: ${file(./odin.yml)} suggested to us that we can make a odin-custom.yml file and plug it in serverless.yml, and the configuration from it would be used everywhere. However, odin.yml is also hardcoded into odin-config-loader.js as const odinConfig = safeLoad(readFileSync('odin.yml', 'utf8'));. This meant half of the config came from our odin-custom.yml, and the other half from the default odin.yml
Suggest pulling the config filename from a single source, with the filename defaulting to odin.yml if not specified. Maybe in serverless.env.yml?
We're happy to do a PR if you think it's a good idea.
Cheers!
The text was updated successfully, but these errors were encountered:
I'm so glad this has been helpful, and so sorry for the confusion leading to UAT being removed!
I think that's a wonderful recommendation and I welcome any work you're able to provide as a PR. I understand things can get in the way, so if you're unable to do that I'll look into this more in a few weeks when I have more availability.
Hi, first of all many thanks for developing and open sourcing this! It is much appreciated and we thought we could maybe give something back by helping improve it.
We got caught out by the config specifying
odin.yml
in two separate places today after noticing it had nuked ourUAT
stages when we had configured it to not.The custom variable under
odin: ${file(./odin.yml)}
suggested to us that we can make aodin-custom.yml
file and plug it in serverless.yml, and the configuration from it would be used everywhere. However, odin.yml is also hardcoded into odin-config-loader.js asconst odinConfig = safeLoad(readFileSync('odin.yml', 'utf8'));
. This meant half of the config came from our odin-custom.yml, and the other half from the defaultodin.yml
Suggest pulling the config filename from a single source, with the filename defaulting to
odin.yml
if not specified. Maybe inserverless.env.yml
?We're happy to do a PR if you think it's a good idea.
Cheers!
The text was updated successfully, but these errors were encountered: