Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify config filename in one place #32

Open
jiscsander opened this issue Apr 28, 2021 · 1 comment
Open

Specify config filename in one place #32

jiscsander opened this issue Apr 28, 2021 · 1 comment

Comments

@jiscsander
Copy link

Hi, first of all many thanks for developing and open sourcing this! It is much appreciated and we thought we could maybe give something back by helping improve it.

We got caught out by the config specifying odin.yml in two separate places today after noticing it had nuked our UAT stages when we had configured it to not.

The custom variable under odin: ${file(./odin.yml)} suggested to us that we can make a odin-custom.yml file and plug it in serverless.yml, and the configuration from it would be used everywhere. However, odin.yml is also hardcoded into odin-config-loader.js as const odinConfig = safeLoad(readFileSync('odin.yml', 'utf8'));. This meant half of the config came from our odin-custom.yml, and the other half from the default odin.yml

Suggest pulling the config filename from a single source, with the filename defaulting to odin.yml if not specified. Maybe in serverless.env.yml?

We're happy to do a PR if you think it's a good idea.

Cheers!

@manwaring
Copy link
Member

I'm so glad this has been helpful, and so sorry for the confusion leading to UAT being removed!

I think that's a wonderful recommendation and I welcome any work you're able to provide as a PR. I understand things can get in the way, so if you're unable to do that I'll look into this more in a few weeks when I have more availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants