Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop QA for Mathare #2

Open
muindre opened this issue Mar 25, 2019 · 6 comments
Open

Develop QA for Mathare #2

muindre opened this issue Mar 25, 2019 · 6 comments

Comments

@muindre
Copy link

muindre commented Mar 25, 2019

https://docs.google.com/spreadsheets/d/1r8NinJojSo7nQy6mD8YSNB5fF4gFLIyQscVhMs5rZpA/edit#gid=0

@mikelmaron
Copy link
Member

@muindre getting a chance to look at this.

First, I updated https://mapkibera.github.io/target/mathare/ with the latest Mathare data from OSM, and the previous QA structure.

Am I to understand that we should resolve all the questions and comments in this spreadsheet and then when settled, I apply it to the QA config for https://mapkibera.github.io/target/mathare/, on the same Mathare data from OSM?

In the spreadsheet, can you remind me about the meaning of the Better tag column, in green? I'm confused between that and comments on the Change to column.

@muindre
Copy link
Author

muindre commented Apr 10, 2019

"Am I to understand that we should resolve all the questions and comments in this spreadsheet and then when settled, I apply it to the QA config for https://mapkibera.github.io/target/mathare/, on the same Mathare data from OSM?"
Yes. that's the plan.
I have already responded to the comments that you left yesterday.

@muindre
Copy link
Author

muindre commented Apr 10, 2019

"First, I updated https://mapkibera.github.io/target/mathare/ with the latest Mathare data from OSM, and the previous QA structure."

Quick one, does the data have to be on OSM already in order to apply to the QA config. The files-mathare data- that I sent you, we have not yet uploaded to OSM.
How did you with the previous test run?

@mikelmaron
Copy link
Member

I have already responded to the comments that you left yesterday.

Thanks I'll take a look

How did you with the previous test run?

It looks like you provided OSM XML and I worked with that. This is the current data you have in staging, correct? I'd have to write something to convert the CSV, possible. If you have as OSM XML, can make it even faster.

@mikelmaron
Copy link
Member

@muindre I have updated https://mapkibera.github.io/target/mathare/ with the data you provided in the spreadsheet. Some of the QA checks have been updated per the Tag list sheet, but sorry I have not had time to do all of them. Please work as much as possible from what you have here, and I'll update again in a week once I'm back.

@muindre
Copy link
Author

muindre commented Apr 15, 2019

It looks like you provided OSM XML and I worked with that. This is the current data you have in staging, correct? I'd have to write something to convert the CSV, possible. If you have as OSM XML, can make it even faster.

Sorry I missed this part. Yes that is the data that we were editing but it still had somethings to fix like changing the 'Ys' to match the correct response.

The data that should have been used is this https://mapkiberatrust.slack.com/archives/CD5F98V2N/p1555323566005100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants