Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks modified by challenge owner are initially listed in history tab as modified by last active mapper #2213

Open
matkoniecz opened this issue Dec 17, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@matkoniecz
Copy link

matkoniecz commented Dec 17, 2023

Describe the bug

tasks modified by challenge owner are initially listed in history tab as modified by last active mapper

looks to be UI bug as reload removes info who modified them (what may be also a bug)

Expected behavior

Person who manually edited task state is listed in history view as one who modified it

To Reproduce

  1. Go to task set as false positive in inspect task mode
  2. Click modify task button
  3. Change status to disabled
  4. Click save
  5. look at history tab

Screenshots

one after stage 5 (I am not mcliquid and I edited it to disable it)

screen05

one after reloading page
screen06

Desktop (please complete the following information):

  • OS: Lubuntu 20.04
  • Browser Firefox
  • Version 120.0.1

Additional context
I guess if many people can have admin rights over challenge then having no log who edited it would be more annoying

@CollinBeczak
Copy link
Collaborator

CollinBeczak commented Feb 29, 2024

Sorry this is has been sitting in "in progress" for some time. Got distracted with resent hot fixes and bugs.

But upon looking at this more, there are two paths to a solution that i can think of. Option 1 is to add new "admin status's" so that challenge owners aren't rewarded points for the leaderboard, or Option 2, tie a "adminChange = true" variable to the task history update.

The reason why this doesn't work right now is because we didn't tie the admin to the history to prevent them from getting points for these changes, and because we never tied the admin to the history, i don't think there is a way for us to fix the currently broken history(history with a blank name similar to the example you described above.). But we can, with the above fixes, solve this issue in for future admin change history updates. Hopefully I will have time to fix this next week and have the fix included in the normal deployment on March 11th.

@matkoniecz
Copy link
Author

no problem! it is not some life-destroying bug and I appreciate that attempt to fix it are ongoing!

It would be definitely nice to see it fixed but it is not of some extreme importance

@CollinBeczak CollinBeczak moved this from In Progress to Planned in MapRoulette Frontend Kanban Board Mar 19, 2024
@CollinBeczak CollinBeczak removed their assignment Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants