-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tasks modified by challenge owner are initially listed in history tab as modified by last active mapper #2213
Comments
Sorry this is has been sitting in "in progress" for some time. Got distracted with resent hot fixes and bugs. But upon looking at this more, there are two paths to a solution that i can think of. Option 1 is to add new "admin status's" so that challenge owners aren't rewarded points for the leaderboard, or Option 2, tie a "adminChange = true" variable to the task history update. The reason why this doesn't work right now is because we didn't tie the admin to the history to prevent them from getting points for these changes, and because we never tied the admin to the history, i don't think there is a way for us to fix the currently broken history(history with a blank name similar to the example you described above.). But we can, with the above fixes, solve this issue in for future admin change history updates. Hopefully I will have time to fix this next week and have the fix included in the normal deployment on March 11th. |
no problem! it is not some life-destroying bug and I appreciate that attempt to fix it are ongoing! It would be definitely nice to see it fixed but it is not of some extreme importance |
Describe the bug
tasks modified by challenge owner are initially listed in history tab as modified by last active mapper
looks to be UI bug as reload removes info who modified them (what may be also a bug)
Expected behavior
Person who manually edited task state is listed in history view as one who modified it
To Reproduce
Screenshots
one after stage 5 (I am not mcliquid and I edited it to disable it)
one after reloading page
Desktop (please complete the following information):
Additional context
I guess if many people can have admin rights over challenge then having no log who edited it would be more annoying
The text was updated successfully, but these errors were encountered: