Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play/Pause fade #249

Open
mateusfg7 opened this issue Mar 29, 2022 · 1 comment · Fixed by #321
Open

Play/Pause fade #249

mateusfg7 opened this issue Mar 29, 2022 · 1 comment · Fixed by #321
Labels
feat New feature or request

Comments

@mateusfg7
Copy link
Owner

Describe new feat

Add a fade when play or pause the sound

Referencies

No response
@mateusfg7 mateusfg7 added the feat New feature or request label Mar 29, 2022
@mateusfg7 mateusfg7 mentioned this issue Jul 14, 2022
Merged
mateusfg7 added a commit that referenced this issue Aug 9, 2023
@mateusfg7
feat(sound): add fade effect on play/pause sound
019b9ee 
This is implementation is heavy inspired by Howler.js fade implementation:
* https://github.com/goldfire/howler.js/blob/9610df82fb93467d62f25a7b1682d534923dc963/src/howler.core.js\#L1295
* https://github.com/goldfire/howler.js/blob/9610df82fb93467d62f25a7b1682d534923dc963/src/howler.core.js\#L1356C13-L1356C13

ref #249
mateusfg7 added a commit that referenced this issue Sep 30, 2023
@mateusfg7
fix(sound)!: remove sound fade in/out effect
85c0af1 
The fade in/or volume functionality when the sound is paused/started was removed due to many inconsistencies, such as not pausing the sound after being clicked. I believe these inconsistencies are due to the asynchronous nature of my implementation.

Ref: #249

BREAKING CHANGE: Fade In/Out volume
@mateusfg7
Copy link
Owner Author

Reopening the issue since I had to remove the already implemented functionality due to inconsistencies and bugs.

I create a GIST with the previous implementation.

@mateusfg7 mateusfg7 reopened this Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Setup Howler.js mateusfg7/Noisekun
1 participant
@mateusfg7