Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a Swift-friendly Base32 library #135

Open
mattrubin opened this issue Feb 9, 2017 · 4 comments
Open

Switch to a Swift-friendly Base32 library #135

mattrubin opened this issue Feb 9, 2017 · 4 comments

Comments

@mattrubin
Copy link
Owner

The current dependency for Base32 encoding and decoding exposes an Objective-C API which doesn't bridge nicely to Swift.

@mattrubin
Copy link
Owner Author

A prerequisite of this is probably converting the last of the legacy tests to Swift, since OTPTokenSerializationTests still uses the Objective-C Base32 interface.

@EmDee
Copy link

EmDee commented Aug 1, 2020

@mattrubin Anything to help out here? I noticed that the current Base32 dependency doesn't play nicely with Swift 5.3.

/cc @nrubin29

@mattrubin
Copy link
Owner Author

@EmDee Help is always welcome! Can you clarify what issues the current dependency has with Swift 5.3? I'm not seeing any issues with Xcode 12 beta 3.

@EmDee
Copy link

EmDee commented Aug 4, 2020

@mattrubin You're right. It was actually a problem on Carthage side (can't tell anymore, if it is due to missing Swift interface file, because the "Build for distribution" flag is not set, or because of this linker issue Carthage/Carthage#3019).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants