Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Set theme using command API ? #657

Closed
tianalemesle opened this issue Apr 22, 2022 · 13 comments
Closed

[Question] Set theme using command API ? #657

tianalemesle opened this issue Apr 22, 2022 · 13 comments

Comments

@tianalemesle
Copy link

Hello,

How can I set AriaNg's theme using the command API ?

Thanks

@mayswind
Copy link
Owner

AriaNg does not provide command API for theme

@KaKi87
Copy link

KaKi87 commented Apr 22, 2022

Could that be added ?
Or, alternatively, use system theme as default instead of light ?
Thanks

@mayswind
Copy link
Owner

  1. This is not a frequently used feature and there is no need to make command api support it.
  2. I want to keep the consistency of the GUI of AriaNg all the times. I don't think it is a good idea that set an option that might break consistency to default value. Although I add dark theme to AriaNg, I always think the dark theme should be set by user own operation.

@KaKi87
Copy link

KaKi87 commented Apr 22, 2022

So, in one hand, there's webui-aria2 which allows setting default configurations for everything but has no dark theme, in the other hand, there's AriaNg which features a dark theme but only allow setting a few default configurations.

Anyone willing to provide both ?

@hapylestat
Copy link

@KaKi87 you can set defaults....by editing aria-ng js file

@KaKi87
Copy link

KaKi87 commented Jul 2, 2022

Which file exactly are you talking about ?
I can't find aria-ng.js.
Thanks

@KaKi87
Copy link

KaKi87 commented Jul 29, 2022

@hapylestat Hello ?

@KaKi87
Copy link

KaKi87 commented Jan 18, 2025

@mayswind What's the answer please ? Thank you

@mayswind
Copy link
Owner

  1. This is not a frequently used feature and there is no need to make command api support it.
  2. I want to keep the consistency of the GUI of AriaNg all the times. I don't think it is a good idea that set an option that might break consistency to default value. Although I add dark theme to AriaNg, I always think the dark theme should be set by user own operation.

@KaKi87 the answer is already posted two years ago

@KaKi87
Copy link

KaKi87 commented Jan 19, 2025

I always think the dark theme should be set by user own operation.

They already did, by enabling dark mode system-wide, that's why prefers-color-scheme exists.

@mayswind
Copy link
Owner

I always think the dark theme should be set by user own operation.

They already did, by enabling dark mode system-wide, that's why prefers-color-scheme exists.

AriaNg provides "follow system setting" option, and use the prefers-color-scheme, but I think the reason why the default option is not set to "follow system setting' is quite clear, as I mentioned before

@KaKi87
Copy link

KaKi87 commented Jan 19, 2025

the reason why the default option is not set to "follow system setting' is quite clear

No it's not.

You say users should set the dark theme manually, but they already did at the system level, so there's no valid reason to make them do it again on that app.

@mayswind
Copy link
Owner

the reason why the default option is not set to "follow system setting' is quite clear

No it's not.

You say users should set the dark theme manually, but they already did at the system level, so there's no valid reason to make them do it again on that app.

Image

Repository owner locked as resolved and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants