titlePreface behavior when disabled

[irvinm]

Steps to reproduce

• Open Firefox in a new profile
• Install Sidebery
  • Leave "Add preface to the browser window's title if sidebar is active" set to OFF
• Install Toggle Native Tab Bar (https://addons.mozilla.org/en-US/firefox/addon/toggle-native-tab-bar/)
  • Configure to work based on https://github.com/irvinm/Toggle-Native-Tab-Bar/blob/main/README.md
  • Uses same basic mechanic based on titlePreface
• Toggle the tab bar via the TNTB addon button to see that it works
• Leave the native tab bar hidden
• Hide Sidebery in the sidebar and see that the Native Tab Bar is shown again

The bottom line is that when the Sidebery option is disabled, showing or hiding the sidebar should have no impact on the titlePreface. It appears to me that this code is called and sets titlePreface when sidebar is hidden.

sidebery/src/bg/background.ts

Lines 102 to 108 in 84807d6

	IPC.onDisconnected(InstanceType.sidebar, winId => {
	Logs.info('IPC.onDisconnected sidebar', winId)
	if (Settings.state.markWindow && Windows.byId[winId]) {
	browser.windows.update(winId, { titlePreface: '' })
	}
	})

There is a discussion on this in the other repository. Since there is no way to "query" the titlePreface so I can't think of a way to work around this from the other addon.

irvinm/Toggle-Native-Tab-Bar#4

Actual behavior

• With "Add preface to the browser window's title if sidebar is active" set to OFF and hiding the sidebar seems to make changes to the titlePreface.

Expected behavior

• Leaving "Add preface to the browser window's title if sidebar is active" set to OFF should not make any changes to the titlePreface regardless of the visibility state of the sidebar.

System

Windows 11

Firefox version

FF133 & FF134

Sidebery version

v5.2

Logs

No response