You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running testflo, the fortran function verifyWarpDeriv. In the inflate_cube test, the output from this test appears to show large errors in some of the derivative terms. However, these error values are not actually used as a unit test and so the entire test suite still passes.
Given how weird the FD values are for the two terms with big errors, it may be that the issue is in those rather than the AD values, but it's hard to see how that could be the case.
As well as fixing these errors, the values computed by verifyWarpDeriv should also be used as unit tests themselves.
Steps to reproduce issue
Please provide a minimum working example (MWE) if possible
Description
When running testflo, the fortran function
verifyWarpDeriv
. In theinflate_cube
test, the output from this test appears to show large errors in some of the derivative terms. However, these error values are not actually used as a unit test and so the entire test suite still passes.Given how weird the FD values are for the two terms with big errors, it may be that the issue is in those rather than the AD values, but it's hard to see how that could be the case.
As well as fixing these errors, the values computed by
verifyWarpDeriv
should also be used as unit tests themselves.Steps to reproduce issue
Please provide a minimum working example (MWE) if possible
testflo -s -n 1 --pre_announce .
Current behavior
Expected behavior
Errors should be ~<1e-4
Code versions
List versions only if relevant
The text was updated successfully, but these errors were encountered: