Machines are unable to accept or process certain recipes #7831

andriihorpenko · 2023-07-28T20:25:11Z

Issue description

Introduction

Frequently, Thermal Evaporation Plant won't accept liquid whatsoever after server reboot.
If you place bucket inside an input slot in GUI, it immediately rejects it and places back into a cursor (video recording below will show exactly how this looks like)
If you try to inject liquid via Thermal Evaporation Valve, liquid will simply not get inside the plant.

This happens frequently, almost every server reboot.

Important things to note

this affects every Thermal Evaporation Plant on the map
reforming a multi structure does not solve the issue (cab be seen on a video)
the only way to solve this issue is to reboot a server a few times until the issue vanishes
there is no error or warning regarding this issue in logs

Steps to reproduce

There is no special reproduction steps and this happens not intentionally.

As I mentioned above, slot inside a GUI rejects a bucket and puts it back into a cursor. I suspect this is some filtering issue.

Of course, I cannot confirm that Mekanism itself is acting up here, it might be some incompatibility or bug. It's just that "slot rejecting bucket" thing makes me lean towards Mekanism.

Screen.Recording.2023-07-28.at.23.16.25.mp4

Minecraft version

1.19.2 (Latest)

Forge version

43.2.17

Mekanism version

10.3.9 (Latest)

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

pupnewfster · 2023-07-29T18:36:51Z

Could you please provide the server's latest log from after it starts and when this issue is occurring? I am curious if any errors are showing in it (either with something causing the recipe to fail to load, or with some exception just being printed to the console).

To be thorough it also would be helpful to have the client's log after they try to place something in the slot as maybe the client is erroring for some reason while doing so.

Also to confirm if you look at the recipes in JEI can you see the water -> brine in the thermal evaporation plant recipe? (This should confirm if it actually loaded or if for some reason the recipe is just not present)

andriihorpenko · 2023-07-29T19:06:27Z

Sure thing! I've collected server and client logs, hope this helps us locate the root cause.

Things to note

Time of my interaction with the Thermal Evaporation Plant: 21:50
JEI always has Thermal Evaporation Plant recipes, even when the issue occurs, so it looks like they are registered correctly
The issue is present right after server is booted and first players find Thermal Evaporation Plant not working
The issue blocks both GUI interaction (bucket bounces back into a cursor) and valve interaction (pipes are unable to push liquid through the valve)

Client log (freshly started client)

latest.log

Server log (been uptime for 3 hours)

latest.log

andriihorpenko · 2023-08-01T15:15:45Z

Small update: the issue also affects Electrolytic Separator. It appears that Thermal Evaporation Plant and Electrolytic Separator break in turns or simultaneously. Let me know if I can provide anything else, this issue is causing quite a hassle.

thiakil · 2023-08-03T07:52:31Z

You appear to have one or more mods crashing during the Attach Capability phase(s), looks like CyclopsCore.

This would explain these things not working

As for pipe issues, if you're using pipes from Mekanism-Evolution, you'll need to report to them instead.

andriihorpenko · 2023-08-03T08:07:27Z

These exceptions are thrown even when the issue with Thermal Evaporation Plant and Electrolytic Separator is not present, and affects a few Immersive Engineering recipes. I can try resolve those exceptions first so we can eliminate them as a potential cause.
Regarding pipes: in my scenario pipes from any mod won’t work(tested on Mekanism, Pipez, Mekanism Evolution)

andriihorpenko · 2023-08-03T19:48:46Z

CyclopsCore developer has fixed those nasty exceptions, however, the issue with Thermal Evaporation Plant and Electrolytic Separator remains precisely the same. No more exceptions are present in logs on any of five running servers.

thiakil · 2023-08-04T00:50:18Z

Please provide fresh server logs from one with the issues

andriihorpenko · 2023-08-04T10:36:17Z

Sure, here is a fresh log with faulty Thermal Evaporation Plants.
2023-08-03-2.log

andriihorpenko · 2023-08-11T22:54:14Z

I keep investigating this issue, here are my findings.
By doing remote debugging, I found out that this validator is returning false, in particular this::containsRecipe.

Mekanism/src/main/java/mekanism/common/content/evaporation/EvaporationMultiblockData.java

Line 115 in a961bcb

    
           fluidTanks.add(inputTank = VariableCapacityFluidTank.input(this, this::getMaxFluid, this::containsRecipe, createSaveAndComparator(recipeCacheLookupMonitor)));

When this happens, BasicFluidTank#insert fails-fast due to isFluidValid(stack) returning false.

Mekanism/src/main/java/mekanism/common/capabilities/fluid/BasicFluidTank.java

Line 179 in a961bcb

    
           if (stack.isEmpty() || !isFluidValid(stack) || !canInsert.test(stack, automationType)) {

Mekanism/src/main/java/mekanism/common/capabilities/fluid/BasicFluidTank.java

Lines 232 to 234 in a961bcb

    
           public boolean isFluidValid(FluidStack stack) { 
        
               return validator.test(stack); 
        
           }

This happens irregularly and I am able to reproduce it on production server with 20+ players.
Do you have any idea why validator may return false? Seems like a recipe issue to me, however, JEI shows recipes correctly.

andriihorpenko · 2023-08-11T23:35:37Z

Here is some more information after further inspection.
BaseInputCache contains these entries:

And this is what createKey returns from the input received.

I see the difference between ForgeFlowingFluid.Source and WaterFluid.Source. This is why ISingleRecipeLookupHandler#containsRecipe returns false, hence, why validator returns false.

UPD: here is a screenshot of a cache state when everything works fine:

As you can see, there are now four entries instead of two. Any ideas why sometimes cache is not populated with all water types?

thiakil · 2023-08-12T05:52:29Z

Do you have any creaftweaker/kubejs/etc scripts that add or change recipes? or any non mekanism mods that do?

andriihorpenko · 2023-08-12T06:11:19Z

Yes, I have KubeJS 6.1 (latest version). However, I don’t have scripts that change Mekanism recipes or affect water in any possible way.

thiakil · 2023-08-14T10:38:12Z

Mekanism-1.19.2-10.3.9.homebaked.zip

Try this build, it'll make more logs.
Trigger the issue on thermal evaps, and then send the server log from startup until the issue (or shutdown).

Should be no need to use this file on the client, it should just slot in

andriihorpenko · 2023-08-14T16:12:04Z

This may take some time to catch this issue. I've installed homebaked version on 5 live servers, waiting patiently for the issue to occur.

andriihorpenko · 2023-08-15T09:19:43Z

Captured the issue: https://pastebin.com/GzFnVb8j
Not sure when exactly it occurred, the server is up for ~ 1 hour.
Usually, the issue reveals itself right after server boot.

thiakil · 2023-08-15T15:38:05Z

Recipe stuff looks fine.

Have you also made sure that the evaporation plants are in a single chunk? (not built partly in one chunk and partly in another)

andriihorpenko · 2023-08-15T15:48:43Z

Yes, all evaporation plants are in a single chunk, we know that placing any multiblock on chunks intersection is generally a bad idea.

andriihorpenko · 2023-08-17T08:55:45Z

New update: Infusion Factory is also affected. However, this time it does not accept even items in slots or via ME interface. Once again, infusion recipes use tags. Something is definitely wrong with the cache.

thiakil · 2023-08-19T05:42:57Z

How are you determining that the recipe is the reason?
in the special version, the TEP will have logged that it failed due to that, which I didn't see any of

andriihorpenko · 2023-08-19T09:01:04Z

Not necessarily the recipes, but recipe input ingredients that use tags. As I mentioned in #7831 (comment), BaseInputCache is missing all necessary inputs. I can't figure out why can this even happen in the first place, but I can be sure that the issue is only with Mekanism, no other mod suffer from this. That is why I assumed that has something to do with the cache as everything points towards t.

thiakil · 2023-08-19T09:31:53Z

It load the recipes from the built in minecraft recipe system, it could be any mod you have interfering

thiakil · 2023-08-19T09:33:00Z

But as I said, your logs didn't indicate it was a problem with the cache at all (as there was no line that I saw that it couldn't locate a recipe)

andriihorpenko · 2023-08-19T12:41:22Z

I think you might be missing a point. Recipes are there, all of them. The issue lays in recipe ingredients. Mekanism’s recipes that use tags in there inputs are failing.

Take a look at my investigation above: normally there should be 4 registered types of water, but in reality there are two. Vanilla’s bucket of water has a tag that is NOT in the cache, that is why TE refuses to accept that water, as there is no recipe matching exactly that tag (WaterFluid != ForgeFlowingFluid)

You can’t see an issue in logs with recipes as recipes themselves are present. And homebacked version of Mekanism logged only cache initialization and clearing, this won’t help us understand why Mekanism sometimes adds only 2 types of water instead of all 4.

thiakil · 2023-08-19T14:43:53Z

You're misunderstanding me.

The log im saying I out that yours didn't get logged is at containsRecipe,

Mekanism/src/main/java/mekanism/common/content/evaporation/EvaporationMultiblockData.java

Line 115 in a961bcb

    
           fluidTanks.add(inputTank = VariableCapacityFluidTank.input(this, this::getMaxFluid, this::containsRecipe, createSaveAndComparator(recipeCacheLookupMonitor)));

Meaning it's not being rejected where you think it is

andriihorpenko · 2023-11-25T18:51:54Z

The new build is on all live servers. It may take some time for the issue to appear again, so I will let you know when this happens and provide a complete log.

andriihorpenko · 2023-11-26T22:36:55Z

This time Metallurgic Infuser has failed and does not accept anything in the input slot (in my case, I tried this recipe).
All recipes are showing up correctly in JEI, as always (this is just for the context).

Here are the logs I gathered:
2023-11-26-1.log

Let me know if this is sufficient to pinpoint the location of the issue and if I should keep monitoring other occurrences of the issue and add them here.

@thiakil

thiakil · 2023-11-26T23:25:26Z

I think I only added the logging for single input recipes (based on the issue being a tep)
I'll have a look at the log later on pc anyway

andriihorpenko · 2023-11-30T19:26:06Z

Is a new build expected any time soon? I am letting you know that we consider removing affected machines and multiblocks (including TEP) from the modpack in approx 1-1.5 weeks, hence, I won't be able to keep investigating this issue afterwards.

thiakil · 2023-12-01T01:52:40Z

why would there be another build?

andriihorpenko · 2023-12-01T04:49:04Z

I assumed you noticed there was insufficient logging.

thiakil · 2023-12-01T04:51:49Z

There's enough to diagnose the water not being a valid input for a tep, which was your initial report.

So waiting on you to provide logs from when that doesn't work. You're free to remove the mods, just means this issue will get closed unresolved until someone else who can reproduce it on 1.19 wants to participate

andriihorpenko · 2023-12-01T08:07:53Z

The issue is much broader and affects not only TEPs, but a bunch of other machines as you can see throughout our investigation. A few days ago I added logs when Metallurgic Infuser broke with the exact same issue, and it did not have water as an input.
Well, if you’re waiting on nothing but TEP failure, I’ll try and catch that.

pupnewfster · 2023-12-02T18:57:27Z

Out of curiosity (and this being more of a side thing), when this issue does affect machines does a /reload cause them to start working again? (TEP or otherwise)

andriihorpenko · 2023-12-02T18:59:52Z

I will try that once the issue arises again as I haven't tried running /reload.

andriihorpenko · 2023-12-08T11:36:30Z

So the TEP issue hasn't appeared yet.
However, Metallurgic Infuser issue has appeared a dozen of times.
I think we should add more logging coverage, including Metallurgic Infuser.
@pupnewfster, /reload has no effect.

UPD: on Dec 16, /reload did help TEP to find all recipes.

andriihorpenko · 2023-12-16T16:58:44Z

@thiakil TEP has failed today, got a log file for you.
@pupnewfster /reload command DID help in this case. From the logs you can clearly see that all recipes got picked up.

Timestamps for the logs:

[16Dec2023 18:15:21.122] - Server boot, Mekanism fails to initialize all recipes for TEP
[16Dec2023 18:49:05.214] - /reload executed, Mekanism got all recipes for TEP

Log file: latest.log

thiakil · 2023-12-17T08:30:58Z

Something seems to be causing your recipes to not load correctly - we use the vanilla recipe stuff with custom types
that, or it's been replaced with a non-tag ingredient

[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: initing recipes for mekanism:evaporating
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: Found fluid tag: mekanism:evaporating/lithium -> forge:brine
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: mekanism:brine
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: mekanism:flowing_brine
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: -------
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: index contents:
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: net.minecraftforge.fluids.ForgeFlowingFluid$Flowing@73cbe6ed : 1 recipes
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: net.minecraftforge.fluids.ForgeFlowingFluid$Source@6496a060 : 1 recipes
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: NBT contents:
[16Dec2023 18:15:21.122] [Server thread/INFO] [mekanism.common.Mekanism/]: -----

vs

[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: initing recipes for mekanism:evaporating
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: Found fluid tag: mekanism:evaporating/brine -> minecraft:water
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: minecraft:water
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: minecraft:flowing_water
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: ad_astra:fuel
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: ad_astra:flowing_fuel
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: ad_astra:oil
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: ad_astra:flowing_oil
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: ad_astra:cryo_fuel
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: ad_astra:flowing_cryo_fuel
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: -------
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: Found fluid tag: mekanism:evaporating/lithium -> forge:brine
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: mekanism:brine
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: mekanism:flowing_brine
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: -------
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: index contents:
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: earth.terrarium.botarium.api.registry.fluid.BotariumFlowingFluid@7c81f0f3 : 1 recipes
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: earth.terrarium.botarium.api.registry.fluid.BotariumFlowingFluid@1cc05212 : 1 recipes
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: earth.terrarium.botarium.api.registry.fluid.BotariumSourceFluid@5dd47067 : 1 recipes
[16Dec2023 19:46:06.521] [Server thread/INFO] [mekanism.common.Mekanism/]: net.minecraftforge.fluids.ForgeFlowingFluid$Flowing@73cbe6ed : 1 recipes
[16Dec2023 19:46:06.522] [Server thread/INFO] [mekanism.common.Mekanism/]: net.minecraftforge.fluids.ForgeFlowingFluid$Source@6496a060 : 1 recipes
[16Dec2023 19:46:06.522] [Server thread/INFO] [mekanism.common.Mekanism/]: earth.terrarium.botarium.api.registry.fluid.BotariumSourceFluid@d82326b : 1 recipes
[16Dec2023 19:46:06.522] [Server thread/INFO] [mekanism.common.Mekanism/]: net.minecraft.world.level.material.WaterFluid$Flowing@3d95100f : 1 recipes
[16Dec2023 19:46:06.522] [Server thread/INFO] [mekanism.common.Mekanism/]: earth.terrarium.botarium.api.registry.fluid.BotariumSourceFluid@5543833e : 1 recipes
[16Dec2023 19:46:06.522] [Server thread/INFO] [mekanism.common.Mekanism/]: earth.terrarium.botarium.api.registry.fluid.BotariumFlowingFluid@2eddb20 : 1 recipes
[16Dec2023 19:46:06.522] [Server thread/INFO] [mekanism.common.Mekanism/]: net.minecraft.world.level.material.WaterFluid$Source@544faa01 : 1 recipes
[16Dec2023 19:46:06.522] [Server thread/INFO] [mekanism.common.Mekanism/]: NBT contents:
[16Dec2023 19:46:06.522] [Server thread/INFO] [mekanism.common.Mekanism/]: -----

andriihorpenko · 2023-12-17T09:49:28Z

Yeah, I see that. I can’t even think of anything that would break recipe loading in such way and be so hard to reproduce.
It’s even weirder that this issue affects Mekanism only.

Anyway, I don’t see what else could be done to find the root cause of the issue. If that’s indeed all what could be done - feel free to close the issue.

thiakil · 2023-12-17T10:16:06Z

The only thing I can think of is to do a binary search, which as noted previously is quite difficult especially given the inconsistency of the issue

Ben-Brady · 2024-04-17T00:05:45Z

I would like to second that I'm also having the same issue, Thermal Evapouration chambers refusing to accept water with the same weird input slot rejecting behaviour the original reporter has.

nayfaan · 2024-06-20T23:56:37Z

Also having the same problem with the PRC not accepting liquid Ethylene to produce HDPE pellets with Mekanism-1.20.1-10.4.8.43

DJteaCosy · 2024-10-10T18:46:39Z

sorry to necro, I'm having the same problem in Valhelsia 6, notably with electrolytic separators. Now watching my fusion reactor slowly fizzle out because I literally can't make deuterium. Let me know if I can supply any logs/files

LKD-PIX · 2024-11-03T23:43:49Z

Huge issue on rotary condensentrator in 1.19.2

BazZziliuS · 2024-11-23T12:51:29Z

Was there any investigation? Can you share any information?

bukowski912 · 2024-11-23T14:17:04Z

List of modpacks reported used here:

Valhesia 6
AllTheMods 8 (ATM 8)

Intersecting mods (modpacks + others):

appleskin
applied-mekanistics
architectury
balm
betterf3
cloth-config
curios
elevatorid
framedblocks
geckolib
iceberg
jei
kubejs
mekanism
mekanism-generators
mekanism-tools
mousetweaks
patchouli
placebo
rhino
spark

Affected blocks:

Thermal Expansion Plant
Metallurgic Infuser
Rotary Condensentrator
Electrolytic Separator
Pressurized Reaction Chamber

This issue evidently affects recipes that use fluid(s).

stdcall0 · 2025-01-01T10:48:40Z

Same issue on ATM 9 TTS with PRC. (plutonium pellet recipe)

pupnewfster added needs review Waiting Feedback 1.19 labels Jul 29, 2023

pupnewfster removed the Waiting Feedback label Aug 1, 2023

andriihorpenko mentioned this issue Aug 3, 2023

Frequent ConcurrentModificationException potentially breaks capabilities of other mods CyclopsMC/CyclopsCore#177

Closed

thiakil mentioned this issue Oct 23, 2023

PRC not accepting Plutonium gas. #7880

Closed

IONayrus mentioned this issue Feb 3, 2024

Metallurgic Infuser - Cant Infuse Iron with Redstone #7988

Closed

pupnewfster changed the title ~~Thermal Evaporation Plant refuses to accept liquid~~ Machines are unable to accept or process certain recipes Feb 21, 2024

This was referenced Feb 21, 2024

Electrolytic Separator won't accept heavy water. #7845

Closed

Rotary Condensentrator not accepting Ethylene #7975

Closed

pupnewfster mentioned this issue May 29, 2024

Ultimate Infusing Factory doesn't accept enriched obsidian #8075

Closed

UnknownSerhan mentioned this issue Jun 28, 2024

PRC not accepting Plutonium gas #8146

Closed

thiakil mentioned this issue Nov 21, 2024

Missing recipes #8261

Closed

BazZziliuS mentioned this issue Jan 8, 2025

Missing recipes BlakeBr0/Cucumber#47

Open

Machines are unable to accept or process certain recipes #7831

Machines are unable to accept or process certain recipes #7831

Comments

andriihorpenko commented Jul 28, 2023

Issue description

Introduction

Important things to note

Steps to reproduce

Minecraft version

Forge version

Mekanism version

Other relevant versions

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

pupnewfster commented Jul 29, 2023

andriihorpenko commented Jul 29, 2023

Things to note

Client log (freshly started client)

Server log (been uptime for 3 hours)

andriihorpenko commented Aug 1, 2023

thiakil commented Aug 3, 2023 • edited Loading

andriihorpenko commented Aug 3, 2023 • edited Loading

andriihorpenko commented Aug 3, 2023

thiakil commented Aug 4, 2023

andriihorpenko commented Aug 4, 2023

andriihorpenko commented Aug 11, 2023

andriihorpenko commented Aug 11, 2023 • edited Loading

thiakil commented Aug 12, 2023

andriihorpenko commented Aug 12, 2023

thiakil commented Aug 14, 2023

andriihorpenko commented Aug 14, 2023

andriihorpenko commented Aug 15, 2023

thiakil commented Aug 15, 2023

andriihorpenko commented Aug 15, 2023

andriihorpenko commented Aug 17, 2023

thiakil commented Aug 19, 2023

andriihorpenko commented Aug 19, 2023

thiakil commented Aug 19, 2023

thiakil commented Aug 19, 2023

andriihorpenko commented Aug 19, 2023

thiakil commented Aug 19, 2023

andriihorpenko commented Nov 25, 2023

andriihorpenko commented Nov 26, 2023 • edited Loading

thiakil commented Nov 26, 2023

andriihorpenko commented Nov 30, 2023

thiakil commented Dec 1, 2023

andriihorpenko commented Dec 1, 2023

thiakil commented Dec 1, 2023

andriihorpenko commented Dec 1, 2023

pupnewfster commented Dec 2, 2023

andriihorpenko commented Dec 2, 2023

andriihorpenko commented Dec 8, 2023 • edited Loading

andriihorpenko commented Dec 16, 2023

thiakil commented Dec 17, 2023

andriihorpenko commented Dec 17, 2023

thiakil commented Dec 17, 2023

Ben-Brady commented Apr 17, 2024

nayfaan commented Jun 20, 2024

DJteaCosy commented Oct 10, 2024

LKD-PIX commented Nov 3, 2024

BazZziliuS commented Nov 23, 2024

bukowski912 commented Nov 23, 2024 • edited Loading

stdcall0 commented Jan 1, 2025

thiakil commented Aug 3, 2023 •

edited

Loading

andriihorpenko commented Aug 3, 2023 •

edited

Loading

andriihorpenko commented Aug 11, 2023 •

edited

Loading

andriihorpenko commented Nov 26, 2023 •

edited

Loading

andriihorpenko commented Dec 8, 2023 •

edited

Loading

bukowski912 commented Nov 23, 2024 •

edited

Loading