Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just an user feedback. #12

Open
rafirafi opened this issue Feb 2, 2015 · 1 comment
Open

Just an user feedback. #12

rafirafi opened this issue Feb 2, 2015 · 1 comment

Comments

@rafirafi
Copy link

rafirafi commented Feb 2, 2015

I've tried a lot of libraries to replace the glu tessselator and this is the first one to give me
consistant (and correct) results.

As a thank you, I want to offer you my first impressions on the api as an user :

Globally the library is easy to use and more expressive than glu (no need to define edgeCallback
to get only triangles, no need to use gluTessNormal to inform that only x and y are used...).

For tessTesselate I've found 'polySize' and 'vertexSize' not to be enought expressive names :
it was not immediatly clear that this was only for defining the output format.

For tessAddContour, it's specified that only tessReal is accepted but :

  • reading the function signature it's not that clear that this means 'only float'
  • it will be nice to have a parameter to specify the type, like it's done in the opengl api,
    so libtess2 could do the conversion internally if necessary

After tessTesselate, the result is accessible throught getter like tessGetVertices. I've not
found (in tesselator.h) how much time the returned arrays are valid. I assume this is till the
next call to tessTesselate, but maybe it's till the next call to tessAddContour, or else ?

If the library segfault, it's not obvious what went wrong even with NDEBUG not defined,
not a big issue as the interface is still simple it's relatively easy to check everything.

Again, theses are just my personnal impressions so feel free to ignore them if you find them
not relevant.

@memononen
Copy link
Owner

Thanks for the feedback, good points!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants