Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMakelists and fix warnings #41

Open
dalboris opened this issue Mar 8, 2022 · 0 comments
Open

Add CMakelists and fix warnings #41

dalboris opened this issue Mar 8, 2022 · 0 comments

Comments

@dalboris
Copy link

dalboris commented Mar 8, 2022

Hi @memononen ,

I know that you're not maintaining this library anymore. Still, I'm currently using it in https://github.com/vgc/vgc, and I've made very small changes:

  • Adding a CMakeLists.txt file
  • Fixing a compiler warning

See: master...vgc:vgc-mods

Would it make sense if I submit pull requests with the above changes, and then if you bump the version to 1.0.3? Note that before doing the PRs, I would improve the CMakeLists.txt a little: I'm currently printing a message which was okay in my use case, but is most likely undesirable for other clients.

One other option might be that I become the official maintainer, if that sounds like something you'd be interested in.

Thanks for this great library,

Boris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant