Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add BMP-390 support to the BMP-3xx sensors #5694

Open
A-c0rN opened this issue Dec 29, 2024 · 0 comments
Open

[Feature Request]: Add BMP-390 support to the BMP-3xx sensors #5694

A-c0rN opened this issue Dec 29, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@A-c0rN
Copy link

A-c0rN commented Dec 29, 2024

Platform

other

Description

The firmware on ScanI2CTwoWire.cpp only supports the BMP-388 device in the BMP-3xx lineup
(See Line 230)
The BME-390 sensor is not at chip address 0x50, and is instead at 0x60.

This could be fixed by adding the following:

                    case 0x60: // BMP-390 should be 0x60
                        logFoundDevice("BMP-390", (uint8_t)addr.address);
                        type = BMP_3XX;
                        break;

On line 237.

@A-c0rN A-c0rN added the enhancement New feature or request label Dec 29, 2024
@fifieldt fifieldt added the good first issue Good for newcomers label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants