[Bug]: Canned message pin configuration doesn't allow zero

[devinmartin]

Category

Other

Hardware

Heltec V3

Firmware Version

2.5.15

Description

The code in the scanAndSelect section of the canned message module does not allow GPIO zero to be configured. It considers a setting of zero to be undefined. This doesn't allow me to use the built in button on the heltec v3 for this function. The code in question is located in src/input/ScanAndSelect.cpp

    if (moduleConfig.canned_message.inputbroker_pin_press)
        pin = moduleConfig.canned_message.inputbroker_pin_press;
    else if (moduleConfig.canned_message.inputbroker_pin_a)
        pin = moduleConfig.canned_message.inputbroker_pin_a;
    else if (moduleConfig.canned_message.inputbroker_pin_b)
        pin = moduleConfig.canned_message.inputbroker_pin_b;
    else
        return false; // Short circuit: no button found

The intent here is good as it prevents unconfigured pins from being used. However the case where an actual value of zero needs to be used won't work.

Relevant log output

No response

[devinmartin]

I pulled the commit hash for the proposed pull request and built and uploaded it to a heltec v3. I can confirm that the change works on a heltec v3 AND that if the user pin is configured to its default setting of GPIO0, that takes priority and the scan and select honors that and doesn't fight with the base functionality.