Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add either total hops or missing hops to RouteDiscovery #501

Closed
ianmcorvidae opened this issue May 20, 2024 · 1 comment
Closed

Add either total hops or missing hops to RouteDiscovery #501

ianmcorvidae opened this issue May 20, 2024 · 1 comment

Comments

@ianmcorvidae
Copy link
Contributor

Related to meshtastic/firmware#3942

Since a traceroute across nodes with 2.3+ firmware will have the hopStart field it is possible to detect any missing hops due to non-decoding repeaters or nodes without the appropriate channel (if hopStart - hopLimit at the target of the traceroute is higher than the length of the list in RouteDiscovery). We could either add the total hops observed (hopStart - hopLimit directly), or the missing hops detected by the final node (hopStart - hopLimit - len(RouteDiscovery list)). The former option would be present on more packets but allow distinguishing when the value has actually been calculated vs. being omitted due to older firmwares, while the latter would most often be 0 and create smaller packets (though probably not significantly0.

@ianmcorvidae
Copy link
Contributor Author

I'm going to close this for now; the discussion on the firmware issue has come to an idea that wouldn't require protobuf changes and I think that's cleaner, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant