[Bug]: CLI duck-types all values for --set irrespective of the field's type

[misterpok]

Category

Serial, WiFi

Hardware

T-Beam

Firmware Version

2.3.4.ea61808

Description

From the CLI, I set the psk to something with a leading zero. Reboot the device, the router does not get a DHCP request. Checking the psk, the leading zero has been dropped.

Disabling wifi, connecting via Bluetooth, then setting the psk is successful, and the CLI now reports the leading 0.

Relevant log output

pok@CENTCOMP:~/Downloads$ meshtastic --set network.wifi_psk 0123456789
Connected to radio
Set network.wifi_psk to 0123456789
Writing modified preferences to device
pok@CENTCOMP:~/Downloads$ meshtastic --get network.wifi_psk
Connected to radio
network.wifi_psk: 123456789
Completed getting preferences

[thebentern]

Python is interpreting this value as a number. You probably need to quote to have it treat this is as a string

[misterpok]

Do you mean simply adding quotes around the psk in the cli command? If so, I get the same result.

pok@CENTCOMP:~/Downloads$ meshtastic --set network.wifi_psk "0987654321"
Connected to radio
Set network.wifi_psk to 0987654321
Writing modified preferences to device
pok@CENTCOMP:~/Downloads$ meshtastic --get network.wifi_psk
Connected to radio
network.wifi_psk: 987654321
Completed getting preferences

[ianmcorvidae]

Yeah, I see the issue here. We'll need to update the code to be aware of the type of the field it's setting; right now it just blindly tries to convert to bytes (with 0x or base64: prefix), boolean (with t, true, yes, f, false, no), int, or float.