Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem loading error message not informative #278

Closed
ronaldtse opened this issue Jul 4, 2022 · 5 comments
Closed

Gem loading error message not informative #278

ronaldtse opened this issue Jul 4, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

I just encountered this issue when using the Git version of metanorma-ieee. This error is not informative to the user, and does not give enough hints for debugging.

We should show the underlying error and also give the user information on where to report this error.

[metanorma] Error: loading gem `metanorma-ieee` failed. Exiting.
@ronaldtse ronaldtse added the bug Something isn't working label Jul 4, 2022
@ronaldtse ronaldtse moved this to Triage in Metanorma Jul 4, 2022
@ronaldtse ronaldtse moved this from Triage to Urgent in Metanorma Jul 4, 2022
CAMOBAP added a commit to metanorma/metanorma that referenced this issue Jul 5, 2022
opoudjis added a commit to metanorma/metanorma that referenced this issue Jul 18, 2022
@CAMOBAP
Copy link
Contributor

CAMOBAP commented Aug 15, 2022

@ronaldtse should we report those errors to processor repos too or it's ok to report it to metanorma-cli repo? Maybe you can suggest a message template?

@ronaldtse
Copy link
Contributor Author

How about something like this?

Error: {error message}
An exception with Metanorma has occurred.

If this problem persists, please report this issue at this link and we shall respond
as soon as we can:

* https://github.com/metanorma/metanorma/issues/new

You may either describe your issue, or opt to attach the generated error report
at `{date-time}-error.log`, which contains additional system information
potentially useful for fixing the issue.

Your valuable feedback is very much appreciated!

- The Metanorma team

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Aug 21, 2022

Ready for review

@ronaldtse
Copy link
Contributor Author

Requested some updates in metanorma/metanorma#254. Thanks!

CAMOBAP added a commit to metanorma/metanorma that referenced this issue Aug 22, 2022
CAMOBAP added a commit to metanorma/metanorma that referenced this issue Sep 21, 2022
opoudjis added a commit to metanorma/metanorma that referenced this issue Sep 26, 2022
@opoudjis
Copy link
Contributor

Closing ticket, since the remaining issue of sanitising user information is a new ticket, #287

Repository owner moved this from 🌋 Urgent to ✅ Done in Metanorma Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants