Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devise support for ActiveJob. Is this gem deprecated? #108

Open
coorasse opened this issue May 2, 2023 · 1 comment
Open

Devise support for ActiveJob. Is this gem deprecated? #108

coorasse opened this issue May 2, 2023 · 1 comment

Comments

@coorasse
Copy link

coorasse commented May 2, 2023

Looking at Devise documentation they support integration with ActiveJob.
In my eyes, this makes this library deprecated. Shall we write it in the README?

@dan-jensen
Copy link

I agree, this gem is probably deprecated.

This gem is still useful for Rails apps that don't use ActiveJob (either they haven't been upgraded to 4.2+ or ActiveJob is deliberately not used), but that's relatively few apps.

I think the only reason this gem would not be considered deprecated is if it were modified to add the ActiveJob integration from the Devise documentation. And there could be some value in that, because then there's no need for "overriding the send_devise_notification method in your model". Model code stays cleaner (and probably better-tested). This gem already follows the same approach, so it shouldn't be a major restructure. But is it worth the effort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants