You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at Devise documentation they support integration with ActiveJob.
In my eyes, this makes this library deprecated. Shall we write it in the README?
The text was updated successfully, but these errors were encountered:
This gem is still useful for Rails apps that don't use ActiveJob (either they haven't been upgraded to 4.2+ or ActiveJob is deliberately not used), but that's relatively few apps.
I think the only reason this gem would not be considered deprecated is if it were modified to add the ActiveJob integration from the Devise documentation. And there could be some value in that, because then there's no need for "overriding the send_devise_notification method in your model". Model code stays cleaner (and probably better-tested). This gem already follows the same approach, so it shouldn't be a major restructure. But is it worth the effort?
Looking at Devise documentation they support integration with ActiveJob.
In my eyes, this makes this library deprecated. Shall we write it in the README?
The text was updated successfully, but these errors were encountered: