You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, most of the styles are contained in a single common Sass partial; this was initially done for efficiency when only elements and console panels were being skinned. With the addition of the elements panel, and (minor) potential for further growth, it makes the current structure unscalable and difficult to maintain.
Ideally, the @mixin styles() itself would not change, avoiding any negative impact on the theme Sass files. The proposed solution would be to use individual @include's within the @mixin styles() itself, and edit the styles as a mixin within unique partials.
Currently, most of the styles are contained in a single common Sass partial; this was initially done for efficiency when only elements and console panels were being skinned. With the addition of the elements panel, and (minor) potential for further growth, it makes the current structure unscalable and difficult to maintain.
app/styles/modules/_common-styles.scss#L2
Ideally, the
@mixin styles()
itself would not change, avoiding any negative impact on the theme Sass files. The proposed solution would be to use individual@include
's within the@mixin styles()
itself, and edit the styles as a mixin within unique partials.The
theme-config.scss
will need to be updated to include the additional partials containing the mixins for building the theme.app/styles/base/_theme-config.scss#L12
The text was updated successfully, but these errors were encountered: