Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change brightness action doesn't work correctly on Samsung devices with Adaptive brightness turned on #14

Open
micku7zu opened this issue Feb 12, 2023 · 0 comments
Labels
bug Something isn't working workaround_available

Comments

@micku7zu
Copy link
Owner

micku7zu commented Feb 12, 2023

Issue description

The "Change brightness" action doesn't work correctly on Samsung devices with Adaptive brightness turned on.

The action changes the brightness to the correct value but the screen brightness it is not changed, or it is changed really slow.

This is a bug from Samsung and can be reproduced with ADB:

  1. Turn on Adaptive brightness
  2. Set the screen brightness with ADB command
    adb shell settings put system screen_brightness 255
    adb shell settings put system screen_brightness 0
  3. The brightness setting will be changed but the actual screen brightness it is not changed, or it is changed really really slow.

Workaround

The only workaround found yet it is to disable the "Adaptive brightness".

There are possible fixes that can be implemented in Quick Cursor but all of them are hacks that are hard to support:

  1. Make Quick Cursor disable adaptive brightness first, and then change the brightness, and then enable adaptive brightness back when the device it is locked. This is a hack that would work but it is hard to support and it can create confussions
  2. Make Quick Cursor change the brightness really slow and repeatedly from value X to Y, by increasing/decreasing the brightness by 1 at a time. I've implemented this but it is a bad user experience that it is hard to support (to explain to users why it works so bad).

So currently there is no acceptable solution to implement in Quick Cursor.

@micku7zu micku7zu self-assigned this Feb 12, 2023
@micku7zu micku7zu added bug Something isn't working workaround_available labels Feb 12, 2023
@micku7zu micku7zu removed their assignment Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workaround_available
Projects
None yet
Development

No branches or pull requests

1 participant