Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ModeManagerNode and ModeMonitorNode themselves lifecycle nodes? #10

Open
ralph-lange opened this issue Feb 7, 2020 · 2 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ralph-lange
Copy link
Contributor

  • Seems natural to use the same concept (i.e. runtime lifecycle) for these to nodes themselves.
  • Yet, in many applications, the mode manager node will be used continuously from system start to shutdown so that there is no need for a runtime lifecycle
  • On the other hand, one might think of a distributed system with multiple mode managers for subsystems which could be deactivated during runtime.
  • If making the two nodes to lifecycle nodes, convenience launch files with auto-activate functionality should be provided.
@norro
Copy link
Collaborator

norro commented Feb 11, 2020

Will definitely have a look at the suggested auto-activate launch functionality, which seems to be a preconditions. Didn't yet manage to implement this, see #11.

@norro
Copy link
Collaborator

norro commented Jul 23, 2021

Since starting mode manager and mode monitor via launch files is the recommended way anyway (see system modes examples), this should be easily doable and comvenient by now.

@norro norro self-assigned this Jul 23, 2021
@norro norro added enhancement New feature or request good first issue Good for newcomers labels Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants