Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about Q.h implement #5

Open
heroboy opened this issue Sep 6, 2023 · 1 comment
Open

Question about Q.h implement #5

heroboy opened this issue Sep 6, 2023 · 1 comment

Comments

@heroboy
Copy link

heroboy commented Sep 6, 2023

I see the implment of shift_right_correctly_by. Is it because:

For negative a, the value of a >> b is implementation-defined (until C++20)

But in multiply<1>, why you don't care to use fpValue1>>P?

And in the implment of operator /=. Why you use left shift directly? Because:

For negative a, the behavior of a << b is undefined.

Looks like it is worse than implementation-defined
@HendrixString
Copy link
Member

Hi @heroboy , I have read your comment, thank you.
I will try to get back to you with discussion at the weekend or start of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heroboy @HendrixString